Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor field-list appearance #179

Open
sadiqkhoja opened this issue Jul 26, 2024 · 0 comments
Open

Refactor field-list appearance #179

sadiqkhoja opened this issue Jul 26, 2024 · 0 comments
Labels

Comments

@sadiqkhoja
Copy link
Contributor

sadiqkhoja commented Jul 26, 2024

1- Alignment of column heading and radio button is out after adding question-container for showing red background for invalid questions.

image

2- We also need to test how the Group component with field-list appearance renders when there are non-select questions with select questions (with list/nolabel-list appearances).

3- From #164 (comment)

However, thinking about whether it is actually dynamic got me to take a closer look at tableLayout. It's also a bit surprising to me that it's computed, at least with the computation it performs. I wouldn't expect it to ever change state (although I admit this is sort of a downside of conveying children as state/reactive regardless of the parent node's type). On the other hand, the way I would expect it to be dynamic is if it took relevance into consideration.

I don't want to address that now, but I do think we should file an issue. And when we get there, I'd like to think about how we can generalize relevance-aware logic: partly so it's composable/reusable because there are probably other places we'd want to do something similar, but mainly as a way to help us remember that relevance is a thing to consider in conditional presentation logic of this sort.

From #164 (comment)

(Not directly related to PR, want to track as it’s come up in recent conversation) FieldListTable naming is confusing. I think we’ve both repeatedly associated it with the field-list appearance, but it is not.

@sadiqkhoja sadiqkhoja added the UI label Jul 26, 2024
@sadiqkhoja sadiqkhoja self-assigned this Jul 26, 2024
@sadiqkhoja sadiqkhoja changed the title [Draft] field-list appearance Refactor field-list appearance Jul 26, 2024
@sadiqkhoja sadiqkhoja removed their assignment Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant