You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1- Alignment of column heading and radio button is out after adding question-container for showing red background for invalid questions.
2- We also need to test how the Group component with field-list appearance renders when there are non-select questions with select questions (with list/nolabel-list appearances).
However, thinking about whether it is actually dynamic got me to take a closer look at tableLayout. It's also a bit surprising to me that it's computed, at least with the computation it performs. I wouldn't expect it to ever change state (although I admit this is sort of a downside of conveying children as state/reactive regardless of the parent node's type). On the other hand, the way I would expect it to be dynamic is if it took relevance into consideration.
I don't want to address that now, but I do think we should file an issue. And when we get there, I'd like to think about how we can generalize relevance-aware logic: partly so it's composable/reusable because there are probably other places we'd want to do something similar, but mainly as a way to help us remember that relevance is a thing to consider in conditional presentation logic of this sort.
(Not directly related to PR, want to track as it’s come up in recent conversation) FieldListTable naming is confusing. I think we’ve both repeatedly associated it with the field-list appearance, but it is not.
The text was updated successfully, but these errors were encountered:
1- Alignment of column heading and radio button is out after adding
question-container
for showing red background for invalid questions.2- We also need to test how the
Group
component withfield-list
appearance renders when there are non-select questions with select questions (with list/nolabel-list appearances).3- From #164 (comment)
From #164 (comment)
The text was updated successfully, but these errors were encountered: