Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support outputs template variable in dependency outputs field #2662

Closed
1 task
Tracked by #2667
carolynvs opened this issue Mar 28, 2023 · 0 comments · Fixed by #3156
Closed
1 task
Tracked by #2667

Support outputs template variable in dependency outputs field #2662

carolynvs opened this issue Mar 28, 2023 · 0 comments · Fixed by #3156
Assignees
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed

Comments

@carolynvs
Copy link
Member

carolynvs commented Mar 28, 2023

When evaluating a dependency's outputs for template syntax, we should support a shorter way of addressing the current dependency's outputs

Instead of ${bundle.dependencies.CURRENT_DEP.outputs.OUTPUT_NAME} the author should be able to use ${outputs.OUTPUT_NAME}. These should be equivalent variables and use the same backing map when the template is resolved.

This variable is only applicable to the outputs section of a dependency. Each template must be evaluated separately, if we want to support this new variable since it is specific to the context in which it's running.

Questions

  • Is this too similar to ${bundle.outputs.OUTPUT_NAME} which stores different data? like it could be ${dependency.outputs.OUTPUT_NAME} instead. 🤷‍♀️

ℹ️ Read PEP003 - Advanced Dependencies for context about how dependencies should work, design details, and notes about desired behavior.

@carolynvs carolynvs added pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed labels Mar 28, 2023
@kichristensen kichristensen self-assigned this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants