Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPublish_RefreshCachedBundle on windows needs rewrite #2858

Open
ludfjig opened this issue Aug 4, 2023 · 0 comments
Open

TestPublish_RefreshCachedBundle on windows needs rewrite #2858

ludfjig opened this issue Aug 4, 2023 · 0 comments
Labels
bug Oops, sorry!

Comments

@ludfjig
Copy link
Contributor

ludfjig commented Aug 4, 2023

Describe the bug

Because of issues with low resolution of the time.Now() on windows, this test usually fails on windows (but passes on linux). The current workaround is to do a time.Sleep(), which is an ugly hack. We should improve the testing by for example mocking the .ModTime()

To Reproduce

Run the test on windows

Expected behavior

The test should pass without time.Sleep()

Porter Command and Output

$ porter [e.g. install --param foo=bar --credential-set azure]
lots of output

Version

Copy the output of porter version below

porter v1.0.15 (be5c66a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops, sorry!
Projects
None yet
Development

No branches or pull requests

1 participant