Various Fixes for Lifter and Unlifter #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusaquilus
added a commit
that referenced
this pull request
Sep 23, 2021
* Fixes/Updates to Lifter/Unlifter * Lifting Fixes. Disabling Ast serialization for quotation test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things in the lifter and unlifter were incorrect. E.g.
Aggregationshould be in the QueryLifter and OnConflict lifting did not exist. This was hidden by the fact that Ast was binary-serialized instead of normally lifted in most cases.A method of telling the
quotemacro not to serialize viainline givenwas introduced to disable Ast serialization for certain tests e.g. quotationspec tests.