-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker re:dash's database init should not rely on the tool used to manage the re:dash's container #628
Comments
I'll try to make something else based on the current image. The best way would be to have an init script into the redash image that can be called the first time instead of supervisor. The problem:
The possible solutions:
|
I'll try to make a POC for the 3rd or the 2nd solution. |
You have a very good point. I like the 1st and 3rd solution. The 3rd should be quite easy to implement considering that Python used for the largest chunk of that script (creating tables). |
pull request #629 implement the 3rd solution. |
Fixed in #1530. |
The philosophy behind "not putting postgresql into containers", is to let you use any postgres server (either one dedicated to re:dash within a docker-compose, or one already used for other databases on your infrastructure).
The fact that, in order to init the database, you HAVE to use docker-compose doesn't provide that flexibility having postgres outside of the container should bring you.
The text was updated successfully, but these errors were encountered: