Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch maven target from using maven to gradle as build system #404

Closed
romtsn opened this issue Jul 11, 2022 · 2 comments
Closed

Switch maven target from using maven to gradle as build system #404

romtsn opened this issue Jul 11, 2022 · 2 comments

Comments

@romtsn
Copy link
Member

romtsn commented Jul 11, 2022

Maven publishing plugin lacks functionality and does not publish Gradle's and Kotlin's metadata. Gradle's publishing plugin has everything working out of the box, so we could use that instead, to have all artifacts published correctly.

For example, this is how the sentry-android artifacts look vs how sqldelight (a kotlin multiplatform lib) looks
https://repo.maven.apache.org/maven2/io/sentry/sentry-android/6.1.4/
https://repo.maven.apache.org/maven2/app/cash/sqldelight/runtime/2.0.0-alpha03/

notice how kotlin-tooling-metadata.json and .module artifacts are missing. They are not mandatory, but may become useful in the future, or if we are gonna use some Gradle's feature like dependency constraints, which is bundled within .module metadata.

@marandaneto
Copy link
Contributor

This should address this issue tho #412

@romtsn
Copy link
Member Author

romtsn commented May 31, 2023

We've decided to not do that, and rather adapt our current publishing workflow to include the aforementioned files using maven instead of switching to gradle.

@romtsn romtsn closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants