Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of SDK.handled values as a lot of events have "--" instead of a value #4036

Open
Angelodaniel opened this issue Sep 13, 2024 · 0 comments
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. onboarding

Comments

@Angelodaniel
Copy link
Member

Image
https://demo.sentry.io/issues/5767541123/?project=1801383&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=0

Android Eng(Stefano): This should be better managed by the backend, and it would affect all the SDKs
One note, though
In our auto-instrumentation we always set it handled to true/false, and we even set it to false when it crashes the app.
There is only one case when we don’t set the flag, or at least only one i can think about now: when the user creates the event, which means it is handled

So I'd say we need to re-evaluate the default behaviour in all of these cases as there are still plenty of issues that have "--" instead of yes/no.

@olksdr olksdr added filler Requires little effort to resolve. Ready to be picked up anytime. onboarding labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. onboarding
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

2 participants