-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make script fails if Registry with Port is used #1
Comments
Oh, that's not great. :( I'll try and get this fixed up today. Thanks for reporting! |
looks like this is still an issue |
Yeah, it definitely is. I haven't had time to address this yet and hasn't been a priority since it's easy to work around just by simply not using the Makefile. |
There's a work around for this, you can do:
Just backslash the troublesome characters. It would also be better to replace your repository in the Makefile so you won't have to deal with this everytime, on my own fork I replaced the first line ( |
This looks like an easy fix for whoever wants to submit a pull request :) |
We've deprecated and removed the Makefile so closing this issue as it is wontfix. |
When using a docker repository like described in:
https://docs.docker.com/registry/deploying/
e.g:
and than using:
REPOSITORY="registry.example:5000/sentry" make build push
the makefile exits with
Makefile:11: *** target pattern contains no '%'. Stop.
The text was updated successfully, but these errors were encountered: