Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make script fails if Registry with Port is used #1

Closed
MaximilianKindshofer opened this issue Jul 22, 2016 · 6 comments
Closed

Make script fails if Registry with Port is used #1

MaximilianKindshofer opened this issue Jul 22, 2016 · 6 comments
Labels

Comments

@MaximilianKindshofer
Copy link

When using a docker repository like described in:

https://docs.docker.com/registry/deploying/
e.g:

docker run -d -p 5000:5000 --restart=always --name registry
-v pwd/certs:/certs
-e REGISTRY_HTTP_TLS_CERTIFICATE=/certs/domain.crt
-e REGISTRY_HTTP_TLS_KEY=/certs/domain.key
registry:2

and than using:

REPOSITORY="registry.example:5000/sentry" make build push

the makefile exits with

Makefile:11: *** target pattern contains no '%'. Stop.

@mattrobenolt
Copy link
Contributor

Oh, that's not great. :( I'll try and get this fixed up today. Thanks for reporting!

@mattrobenolt mattrobenolt self-assigned this Jul 22, 2016
@mfb
Copy link
Contributor

mfb commented Sep 29, 2016

looks like this is still an issue

@mattrobenolt
Copy link
Contributor

Yeah, it definitely is. I haven't had time to address this yet and hasn't been a priority since it's easy to work around just by simply not using the Makefile.

@serafdev
Copy link

serafdev commented Dec 10, 2018

There's a work around for this, you can do:

REPOSITORY="registry.example\:5000/sentry"
make build push

Just backslash the troublesome characters.

It would also be better to replace your repository in the Makefile so you won't have to deal with this everytime, on my own fork I replaced the first line (REPOSITORY?=...) to REPOSITORY?="some-machine\:5000/sentry-onpremise then just use make build push

@BYK
Copy link
Member

BYK commented Jun 10, 2019

This looks like an easy fix for whoever wants to submit a pull request :)

@BYK
Copy link
Member

BYK commented Jan 9, 2020

We've deprecated and removed the Makefile so closing this issue as it is wontfix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants