Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading source files fails in 2.35.0 #2147

Closed
1 of 8 tasks
moritzsur opened this issue Sep 6, 2024 · 3 comments · Fixed by #2146
Closed
1 of 8 tasks

Uploading source files fails in 2.35.0 #2147

moritzsur opened this issue Sep 6, 2024 · 3 comments · Fixed by #2146
Assignees

Comments

@moritzsur
Copy link

moritzsur commented Sep 6, 2024

CLI Version

2.35.0

Operating System and Architecture

  • macOS (arm64)
  • macOS (x86_64)
  • Linux (i686)
  • Linux (x86_64)
  • Linux (armv7)
  • Linux (aarch64)
  • Windows (x86_64)
  • Windows (i686)

Operating System Version

macOS 14.6.1

Link to reproduction repository

No response

CLI Command

sentry-cli debug-files upload -o <...> -p <...> cmake-build-debug/dsymutil_out --wait --log-level=trace --include-sources

Exact Reproduction Steps

  1. build a project with cmake and ninja on macOS
  2. manually create dSYM
# go to build folder
cd cmake-build-debug

# generate the required debug files post build (dSYM files on macos)
dsymutil GainAimPro_artefacts/Debug/VST3/GainAimPro.vst3/Contents/MacOS/GainAimPro --out dsymutil_out

# verify
sentry-cli debug-files check ./dsymutil_out/Contents/Resources/DWARF/GainAimPro
  1. uploading it
sentry-cli debug-files upload -o <...> -p gainaimpro cmake-build-debug/dsymutil_out --wait --include-sources

Expected Results

Uploading all sources files and the manually generated debug file.

Actual Results

No source file/debug file is being uploaded.

Logs

<...>
DEBUG 2024-09-06 16:41:28.990919 +02:00 Trying to add source file: /Users/moritzsurwehme/repos/nw_plugins/JUCE/modules/juce_core/zip/zlib/inflate.h
DEBUG 2024-09-06 16:41:28.991263 +02:00 Trying to add source file: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWorkspace.h
DEBUG 2024-09-06 16:41:28.992113 +02:00 Trying to add source file: /Users/moritzsurwehme/repos/nw_plugins/JUCE/modules/juce_core/network/juce_MACAddress.h
DEBUG 2024-09-06 16:41:28.992484 +02:00 Trying to add source file: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/TextCommon.h
DEBUG 2024-09-06 16:41:28.993604 +02:00 Trying to add source file: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/UnicodeConverter.h
error: file could not be read as UTF-8
caused by: stream did not contain valid UTF-8
INFO 2024-09-06 16:41:28.999108 +02:00 Skipping update nagger update check

@szokeasaurusrex
Copy link
Member

Hey @moritzsur, I believe I have already fixed the bug you are experiencing upstream in symbolic, but the version we are currently using in Sentry CLI does not contain this fix yet. I will bump symbolic and release a new Sentry CLI version with the updated dependency; please let me know whether it fixes the problem.

@szokeasaurusrex
Copy link
Member

@moritzsur, the fix has been released in 2.36.0. If you continue experiencing this error, please re-open the issue, and I'll be happy to investigate further.

@moritzsur
Copy link
Author

Works now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants