From 149877e1aea57cba3594c26a138348f83233f25c Mon Sep 17 00:00:00 2001 From: Philipp Hofmann Date: Wed, 16 Oct 2024 11:32:45 +0200 Subject: [PATCH] impr: Align SDK dispatch queue names (#4442) All dispatch queues now start with the prefix . --- CHANGELOG.md | 1 + Sources/Sentry/SentryDispatchQueueWrapper.m | 2 +- Sources/Sentry/SentryPerformanceTrackingIntegration.m | 2 +- Sources/Sentry/SentryTransportFactory.m | 2 +- Sources/Sentry/SentryWatchdogTerminationTrackingIntegration.m | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e581eba094..69022a58539 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ via the option `swizzleClassNameExclude`. - Serializing profile on a BG Thread (#4377) to avoid potentially slightly blocking the main thread. - Session Replay performance for SwiftUI (#4419) - Speed up getBinaryImages (#4435) for finishing transactions and capturing events +- Align SDK dispatch queue names (#4442) to start with `io.sentry` - Use UInts in envelope deserialization (#4441) ## 8.38.0 diff --git a/Sources/Sentry/SentryDispatchQueueWrapper.m b/Sources/Sentry/SentryDispatchQueueWrapper.m index f0104861a4f..96cf89e65bb 100644 --- a/Sources/Sentry/SentryDispatchQueueWrapper.m +++ b/Sources/Sentry/SentryDispatchQueueWrapper.m @@ -12,7 +12,7 @@ - (instancetype)init // iOS 9 we need to manually add the autoreleasepool. dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class( DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); - self = [self initWithName:"sentry-default" attributes:attributes]; + self = [self initWithName:"io.sentry.default" attributes:attributes]; return self; } diff --git a/Sources/Sentry/SentryPerformanceTrackingIntegration.m b/Sources/Sentry/SentryPerformanceTrackingIntegration.m index 4975d4ef9e5..8f2eb8a2098 100644 --- a/Sources/Sentry/SentryPerformanceTrackingIntegration.m +++ b/Sources/Sentry/SentryPerformanceTrackingIntegration.m @@ -29,7 +29,7 @@ - (BOOL)installWithOptions:(SentryOptions *)options dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class( DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_HIGH, 0); SentryDispatchQueueWrapper *dispatchQueue = - [[SentryDispatchQueueWrapper alloc] initWithName:"sentry-ui-view-controller-swizzling" + [[SentryDispatchQueueWrapper alloc] initWithName:"io.sentry.ui-view-controller-swizzling" attributes:attributes]; SentrySubClassFinder *subClassFinder = [[SentrySubClassFinder alloc] diff --git a/Sources/Sentry/SentryTransportFactory.m b/Sources/Sentry/SentryTransportFactory.m index 65dddc900d5..cbdd10e5990 100644 --- a/Sources/Sentry/SentryTransportFactory.m +++ b/Sources/Sentry/SentryTransportFactory.m @@ -59,7 +59,7 @@ @implementation SentryTransportFactory dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class( DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_LOW, 0); SentryDispatchQueueWrapper *dispatchQueueWrapper = - [[SentryDispatchQueueWrapper alloc] initWithName:"sentry-http-transport" + [[SentryDispatchQueueWrapper alloc] initWithName:"io.sentry.http-transport" attributes:attributes]; SentryNSURLRequestBuilder *requestBuilder = [[SentryNSURLRequestBuilder alloc] init]; diff --git a/Sources/Sentry/SentryWatchdogTerminationTrackingIntegration.m b/Sources/Sentry/SentryWatchdogTerminationTrackingIntegration.m index 65a8126cbde..7d62a0a16cf 100644 --- a/Sources/Sentry/SentryWatchdogTerminationTrackingIntegration.m +++ b/Sources/Sentry/SentryWatchdogTerminationTrackingIntegration.m @@ -53,7 +53,7 @@ - (BOOL)installWithOptions:(SentryOptions *)options dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class( DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_HIGH, 0); SentryDispatchQueueWrapper *dispatchQueueWrapper = - [[SentryDispatchQueueWrapper alloc] initWithName:"sentry-out-of-memory-tracker" + [[SentryDispatchQueueWrapper alloc] initWithName:"io.sentry.watchdog-termination-tracker" attributes:attributes]; SentryFileManager *fileManager = [[[SentrySDK currentHub] getClient] fileManager];