Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Instrumentation for Dart's io HttpClient #1484

Closed
silverhairs opened this issue May 25, 2023 · 1 comment
Closed

Sentry Instrumentation for Dart's io HttpClient #1484

silverhairs opened this issue May 25, 2023 · 1 comment

Comments

@silverhairs
Copy link

Problem Statement

Out of the box, when performing http request in things such as the NetworkImage widget or the CachedNetworkImagePackage flutter uses dart's io HttpClient class. Currently Sentry does not have a package to instrument that. It's easy to override the underlying HttpClient with a custom implementation by extending HttpOverrides and overriding the createHttpClient method; but there is no implementation of HttpClient with sentry, and we cannot pass dio and http.Client as none of them implement HttpClient.

I think it would be important for sentry to support the native classes before going into the 3rd party libraries, this will reduce dependency on external libraries, and developers will not be obliged to always depend on a 3rd parties if I just want to instrument all network requests.

Solution Brainstorm

Extend HttpClient and HttpOverrides and make it easier for developers to perform instrumentations.

I could investigate this and submit a PR but I cannot really promise anything for now as I have little availability.

Are you willing to submit a PR?

None

@marandaneto
Copy link
Contributor

Dupe #539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants