You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Out of the box, when performing http request in things such as the NetworkImage widget or the CachedNetworkImagePackage flutter uses dart's io HttpClient class. Currently Sentry does not have a package to instrument that. It's easy to override the underlying HttpClient with a custom implementation by extending HttpOverrides and overriding the createHttpClient method; but there is no implementation of HttpClient with sentry, and we cannot pass dio and http.Client as none of them implement HttpClient.
I think it would be important for sentry to support the native classes before going into the 3rd party libraries, this will reduce dependency on external libraries, and developers will not be obliged to always depend on a 3rd parties if I just want to instrument all network requests.
Solution Brainstorm
Extend HttpClient and HttpOverrides and make it easier for developers to perform instrumentations.
I could investigate this and submit a PR but I cannot really promise anything for now as I have little availability.
Are you willing to submit a PR?
None
The text was updated successfully, but these errors were encountered:
Problem Statement
Out of the box, when performing http request in things such as the
NetworkImage
widget or theCachedNetworkImagePackage
flutter uses dart's io HttpClient class. Currently Sentry does not have a package to instrument that. It's easy to override the underlyingHttpClient
with a custom implementation by extending HttpOverrides and overriding thecreateHttpClient
method; but there is no implementation ofHttpClient
with sentry, and we cannot pass dio and http.Client as none of them implementHttpClient
.I think it would be important for sentry to support the native classes before going into the 3rd party libraries, this will reduce dependency on external libraries, and developers will not be obliged to always depend on a 3rd parties if I just want to instrument all network requests.
Solution Brainstorm
Extend
HttpClient
andHttpOverrides
and make it easier for developers to perform instrumentations.I could investigate this and submit a PR but I cannot really promise anything for now as I have little availability.
Are you willing to submit a PR?
None
The text was updated successfully, but these errors were encountered: