Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Package_info_plus to version 6 #1944

Closed
Bilonik opened this issue Mar 20, 2024 · 4 comments · Fixed by #1948
Closed

Upgrade Package_info_plus to version 6 #1944

Bilonik opened this issue Mar 20, 2024 · 4 comments · Fixed by #1948
Assignees

Comments

@Bilonik
Copy link

Bilonik commented Mar 20, 2024

Description

sentry_flutter 7.18.0 depends on package_info_plus >=1.0.0 <=5.0.1

@kuhnroyal
Copy link
Contributor

Judging from the changelog, there are no changes to API. Only SDK constraints and WASM support, so this should theoretically just work with an override.

@kahest kahest moved this from Needs Discussion to Needs Investigation in Mobile & Cross Platform SDK Mar 22, 2024
@kahest
Copy link
Member

kahest commented Mar 22, 2024

Hey, thanks for bringing this to our attention, we'll take a look

@denrase denrase moved this from Needs Investigation to In Progress in Mobile & Cross Platform SDK Mar 25, 2024
@denrase
Copy link
Collaborator

denrase commented Mar 25, 2024

Just checked the Changelog , where version 6.0.0 depends upon:

Dependency Current Version New Version
Flutter >= 3.0.0 >=3.19.0
Dart >= 2.17.0 >=3.3.0
macOS 10.13 10.14
Android Target SDK 33 34
Android Java VERSION_1_8 VERSION_17
Android Gradle 7.2.2 8.4

Since the version is provided as a range, we probably don't have to upgrade all of them, as the dependency resolution will find compatible versions when we provide a range.

@denrase denrase mentioned this issue Mar 25, 2024
6 tasks
@kuhnroyal
Copy link
Contributor

Just checked the Changelog , where version 6.0.0 depends upon:

Dependency Current Version New Version
Flutter >= 3.0.0 >=3.19.0
Dart >= 2.17.0 >=3.3.0
macOS 10.13 10.14
Android Target SDK 33 34
Android Java VERSION_1_8 VERSION_17
Android Gradle 7.2.2 8.4
Since the version is provided as a range, we probably don't have to upgrade all of them, as the dependency resolution will find compatible versions when we provide a range.

This should not matter, this is the responsibility of the implementor.
Increasing the range just would allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants