Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry.autoDiscoverNodePerformanceMonitoringIntegrations doesn't seem to exist #7221

Closed
oliversalzburg opened this issue Jun 20, 2023 · 4 comments · Fixed by #7245
Closed

Comments

@oliversalzburg
Copy link

Core or SDK?

Core Sentry product

Which part? Which one?

AWS Lambda

Description

https://docs.sentry.io/platforms/node/guides/aws-lambda/performance/instrumentation/automatic-instrumentation refers to Sentry.autoDiscoverNodePerformanceMonitoringIntegrations, which doesn't seem to exist.

In particular, this is surprising, because I'm viewing the serverless-related documentation, and this page is using the node package. The latter exports the referenced method, but not the serverless package, that you'll be using in AWS Lambda.

Suggested Solution

Re-export the method from node in the serverless package or fix the docs.

@getsantry
Copy link
Contributor

getsantry bot commented Jun 20, 2023

Assigning to @getsentry/support for routing, due by Tuesday, June 20th at 5:00 pm (sfo). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Jun 20, 2023

Routing to @getsentry/product-owners-sdks-web-frontend for triage, due by Thursday, June 22nd at 17:00 (vie). ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 Jun 20, 2023
@Lms24
Copy link
Member

Lms24 commented Jun 22, 2023

Hi @oliversalzburg, thanks for raising this! Seems like we missed to export this function from our @sentry/serverless SDK when we internally refactored our tracing package.
For the sake of consistency we'll add the missing export to the SDK. However, we'll also adjust the docs with a warning that using this functionality comes with a potentially hefty performance impact that can significantly increase the runtime of a serverless function. Auto-discovery checks if certain database tools (e.g. Apollo, Postgres, etc) are installed by dynamically requiring them. This takes some time.

@oliversalzburg
Copy link
Author

Oh, interesting. Thanks for the heads-up 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
3 participants