From b52b1228b4aecef0bb9a34e996060bf6bcffc5e8 Mon Sep 17 00:00:00 2001 From: Charly Gomez Date: Wed, 16 Oct 2024 09:48:46 +0200 Subject: [PATCH] docs(js): Fix default integration examples --- .../multiple-sentry-instances.mdx | 38 ++++++++++--------- .../best-practices/shared-environments.mdx | 15 +++----- 2 files changed, 26 insertions(+), 27 deletions(-) diff --git a/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx b/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx index d2fc2efe087a7..023eaee70d9e9 100644 --- a/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx +++ b/docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx @@ -37,18 +37,19 @@ import { Scope, } from "@sentry/browser"; -// filter integrations that use the global variable -const integrations = getDefaultIntegrations({}).filter((defaultIntegration) => { - return !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes( - defaultIntegration.name - ); -}); const client = new BrowserClient({ dsn: "___PUBLIC_DSN___", transport: makeFetchTransport, stackParser: defaultStackParser, - integrations: integrations, + // filter integrations that use the global variable + integrations: (defaultIntegrations) => + defaultIntegrations.filter( + (integration) => + !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes( + integration.name + ) + ), }); const scope = new Scope(); @@ -89,20 +90,18 @@ function happyIntegration() { }; } -// filter integrations that use the global variable -const integrations = Sentry.getDefaultIntegrations({}).filter( - (defaultIntegration) => { - return !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes( - defaultIntegration.name - ); - } -); const client1 = new Sentry.BrowserClient({ dsn: "___PUBLIC_DSN___", transport: Sentry.makeFetchTransport, stackParser: Sentry.defaultStackParser, - integrations: [...integrations, happyIntegration()], + // filter integrations that use the global variable + integrations: (defaultIntegrations) => [ + ...defaultIntegrations.filter( + (integration) => !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(integration.name) + ), + happyIntegration(), + ], beforeSend(event) { console.log("client 1", event); return null; // Returning `null` prevents the event from being sent @@ -115,7 +114,12 @@ const client2 = new Sentry.BrowserClient({ dsn: "___PUBLIC_DSN___", // Can be a different DSN transport: Sentry.makeFetchTransport, stackParser: Sentry.defaultStackParser, - integrations: [...integrations, happyIntegration()], + integrations: (defaultIntegrations) => [ + ...defaultIntegrations.filter( + (integration) => !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(integration.name) + ), + happyIntegration(), + ], beforeSend(event) { console.log("client 2", event); return null; // Returning `null` prevents the event from being sent diff --git a/docs/platforms/javascript/common/best-practices/shared-environments.mdx b/docs/platforms/javascript/common/best-practices/shared-environments.mdx index 5de050f9b9330..a5b91187092ce 100644 --- a/docs/platforms/javascript/common/best-practices/shared-environments.mdx +++ b/docs/platforms/javascript/common/best-practices/shared-environments.mdx @@ -59,20 +59,15 @@ import { Scope, } from "@sentry/browser"; -// filter integrations that use the global variable -const integrations = getDefaultIntegrations({}).filter((defaultIntegration) => { - return ![ - "BrowserApiErrors", - "Breadcrumbs", - "GlobalHandlers", - ].includes(defaultIntegration.name); -}); - const client = new BrowserClient({ dsn: "___PUBLIC_DSN___", transport: makeFetchTransport, stackParser: defaultStackParser, - integrations: integrations, + // filter integrations that use the global variable + integrations: (defaultIntegrations) => + defaultIntegrations.filter( + (integration) => !["BrowserApiErrors", "Breadcrumbs", "GlobalHandlers"].includes(integration.name) + ), }); const scope = new Scope();