From 98e47bc6ad76c759bdd733207105f000e6d29e4e Mon Sep 17 00:00:00 2001
From: Bruno Garcia <bruno@brunogarcia.com>
Date: Fri, 27 Jul 2018 10:45:48 +0200
Subject: [PATCH] Multi target: ns2.0, ns1.3, net46 * Run tests against each
 target * Remove any dependency from ns2.0!

---
 Directory.Build.props                            |  1 +
 src/Sentry.Protocol/Dsn.cs                       |  2 +-
 src/Sentry.Protocol/Sentry.Protocol.csproj       | 13 ++++++++++++-
 .../Sentry.Protocol.Tests.csproj                 | 16 +++++++++++++---
 4 files changed, 27 insertions(+), 5 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 944da9d3f9..2ef2f63e71 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -18,6 +18,7 @@
     <BaseFrameworkPathOverrideForMono Condition="'$(BaseFrameworkPathOverrideForMono)' == '' AND '$(TargetIsMono)' == 'true' AND EXISTS('/usr/local/lib/mono')">/usr/local/lib/mono</BaseFrameworkPathOverrideForMono>
 
     <!-- If we found Mono reference assemblies, then use them -->
+    <FrameworkPathOverride Condition="'$(BaseFrameworkPathOverrideForMono)' != '' AND '$(TargetFramework)' == 'net46'">$(BaseFrameworkPathOverrideForMono)/4.6-api</FrameworkPathOverride>
     <FrameworkPathOverride Condition="'$(BaseFrameworkPathOverrideForMono)' != '' AND '$(TargetFramework)' == 'net462'">$(BaseFrameworkPathOverrideForMono)/4.6.2-api</FrameworkPathOverride>
     <EnableFrameworkPathOverride Condition="'$(BaseFrameworkPathOverrideForMono)' != ''">true</EnableFrameworkPathOverride>
   </PropertyGroup>
diff --git a/src/Sentry.Protocol/Dsn.cs b/src/Sentry.Protocol/Dsn.cs
index 208510de80..8a20d3c5cc 100644
--- a/src/Sentry.Protocol/Dsn.cs
+++ b/src/Sentry.Protocol/Dsn.cs
@@ -76,7 +76,7 @@ private Dsn(string dsn, string projectId, string path, string secretKey, string
         ///   <c>true</c> if the string represents a disabled DSN; otherwise, <c>false</c>.
         /// </returns>
         public static bool IsDisabled(string dsn) =>
-            Constants.DisableSdkDsnValue.Equals(dsn, StringComparison.InvariantCultureIgnoreCase);
+            Constants.DisableSdkDsnValue.Equals(dsn, StringComparison.OrdinalIgnoreCase);
 
         /// <summary>
         /// Tries to parse the string into a <see cref="Dsn"/>
diff --git a/src/Sentry.Protocol/Sentry.Protocol.csproj b/src/Sentry.Protocol/Sentry.Protocol.csproj
index ce154c3118..26c0906f68 100644
--- a/src/Sentry.Protocol/Sentry.Protocol.csproj
+++ b/src/Sentry.Protocol/Sentry.Protocol.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>netstandard2.0;netstandard1.3;net46</TargetFrameworks>
     <LangVersion>7.2</LangVersion>
     <PackageId>Sentry.Protocol</PackageId>
     <AssemblyName>Sentry.Protocol</AssemblyName>
@@ -9,4 +9,15 @@
     <Description>The Sentry Protocol used to communicate with Sentry - Open-source error tracking that helps developers monitor and fix crashes in real time.</Description>
   </PropertyGroup>
 
+  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
+    <PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
+    <PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.0" />
+    <PackageReference Include="System.Collections.Concurrent" Version="4.3.0" />
+    <PackageReference Include="System.ValueTuple" Version="4.3.0" />
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(TargetFramework)' == 'net46'">
+    <PackageReference Include="System.ValueTuple" Version="4.5.0" />
+  </ItemGroup>
+
 </Project>
diff --git a/test/Sentry.Protocol.Tests/Sentry.Protocol.Tests.csproj b/test/Sentry.Protocol.Tests/Sentry.Protocol.Tests.csproj
index c3c7d34c5f..aa205166b5 100644
--- a/test/Sentry.Protocol.Tests/Sentry.Protocol.Tests.csproj
+++ b/test/Sentry.Protocol.Tests/Sentry.Protocol.Tests.csproj
@@ -1,11 +1,21 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;netcoreapp2.0;net462</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.1;netcoreapp2.0</TargetFrameworks>
+    <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
   </PropertyGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="../../src/Sentry.Protocol/Sentry.Protocol.csproj" />
+  <ItemGroup Condition="'$(TargetFramework)' == 'net462'">
+    <Reference Include="System.Threading.Tasks" />
+    <ProjectReference Include="../../src/Sentry.Protocol/Sentry.Protocol.csproj" Properties="TargetFramework=net46" />
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.0'">
+    <ProjectReference Include="../../src/Sentry.Protocol/Sentry.Protocol.csproj" Properties="TargetFramework=netstandard1.3" />
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.1'">
+    <ProjectReference Include="../../src/Sentry.Protocol/Sentry.Protocol.csproj" Properties="TargetFramework=netstandard2.0" />
   </ItemGroup>
 
   <ItemGroup>