Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for Metrics API #3066

Closed
jamescrosswell opened this issue Jan 21, 2024 · 0 comments · Fixed by #3094
Closed

Improve test coverage for Metrics API #3066

jamescrosswell opened this issue Jan 21, 2024 · 0 comments · Fixed by #3094
Assignees
@jamescrosswell

Comments

@jamescrosswell
Copy link
Collaborator

We intentionally went light on unit tests when building out the Metrics API. Now that the spec is stabilizing/maturing, we should revisit code coverage for the changes in:

Earlier decision

There are actually develop docs on this: https://develop.sentry.dev/delightful-developer-metrics/sending-metrics-sdk/

Please note this is very early stage so not worth adding a ton of tests, we could have this on a branch and ship alpha's from it for example

Originally posted by @bruno-garcia in #2880 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

Labels
None yet
Projects
GDX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve code coverage for Metrics getsentry/sentry-dotnet
1 participant
@jamescrosswell