UWP: "In foreground" context warning + not working

[tipa]

Package

Sentry

.NET Flavor

.NET

.NET Version

.NET Standard 2.0

OS

Windows

SDK Version

4.2.1

Self-Hosted Sentry Version

No response

Steps to Reproduce

• Use Sentry in a UWP app
• Build in Release mode
• trigger crash while app window is in foreground

Expected Result

1. no warning during build
2. "In Foreground" context shows as "True" in Sentry

Actual Result

1. Warning during build:

C:\Users\user\.nuget\packages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :
       MCG : warning MCG0007: Unresolved P/Invoke method 'user32.dll!GetWindowThreadProcessId' for method 'System.Int32 Sentry.Internal.ProcessInfo.GetWindowThreadProcessId(System.IntPtr, System.Int32)'. 
Calling this method would throw exception at runtime. 
Please make sure the P/Invoke either points to a Windows API allowed in UWP applications, or a native DLL that is part of the package. 
If for some reason your P/Invoke does not satisfy those requirements, please use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP A 

2. "In Foreground" shows as "false" in Sentry

[tipa]

Some more context:

The code was introduced in this PR: c0e9a3d

I copied the code and executed it in both a UWP and a WinUI3 / WinAppSDK app:

• in the WinUI3 app, the code worked as expected, the ApplicationIsActivated method returned true when the window was in the foreground and false, if it was not
• In the UWP app, the ApplicationIsActivated method always returned false

Perhaps, on UWP the Window.Current.Visible property could serve as a workaround, however it returns true even when the window is visible but not focused. Another option is to use CoreWindow.GetForCurrentThread().ActivationMode which returns ActivatedInForeground when the app is in foreground and focused

[jamescrosswell]

Thanks so much for the sleuthing @tipa ! CoreWindow.GetForCurrentThread().ActivationMode sounds promising...

[jamescrosswell]

We can't use CoreWindow.GetForCurrentThread() without adding an unacceptable dependency to the core Sentry package or, alternatively, creating a separate Sentry.UWP package... which is unlikely any time soon.

It looks like the original issue with GetForegroundWindow is part of the basic design for UWP (UWP apps don't have any Window Handle).

At this point, I can't see an easy way around this one... @bitsandfoxes @vaind any ideas?

[tipa]

If there's no easy solution to the problem, setting the Foreground context could just be disabled on UWP so that at least the build warning disappears? If a developer wants to add the information, he could still enrich the event himself

[bitsandfoxes]

at least the build warning disappears

I think this is the way to go.

[tipa]

Just to confirm that the GetWindowThreadProcessId method is not available on UWP:

[bitsandfoxes]

We discussed maybe just suppressing the waring via pragma as this is getting caught by the ProcessInfo already.