Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oban Cron: provide a way to set owner of monitor #824

Open
Miradorn opened this issue Dec 2, 2024 · 10 comments · May be fixed by #829
Open

Oban Cron: provide a way to set owner of monitor #824

Miradorn opened this issue Dec 2, 2024 · 10 comments · May be fixed by #829
Assignees

Comments

@Miradorn
Copy link

Miradorn commented Dec 2, 2024

Hi there and thanks for the great library!

I'm wondering wether it would be possible to provide a way to set the owner of a cron monitor via the automatic integration?

We have a setup where we know the owning Sentry team in our codebase and if we could somehow tell the integration to set it correctly it would ease our debugging flow a lot.

e.g. by specifying a callback or some kind of mapping. You probably know best how to achieve it!

Thanks ❤

@sl0thentr0py
Copy link
Member

@Miradorn this is not part of the SDK payload protocol, so we cannot assign owners from the SDK. I will transfer this to the product repo as a feature request.

@sl0thentr0py sl0thentr0py transferred this issue from getsentry/sentry-elixir Dec 3, 2024
@getsantry
Copy link

getsantry bot commented Dec 3, 2024

Routing to @getsentry/product-owners-crons for triage ⏲️

@getsantry
Copy link

getsantry bot commented Dec 3, 2024

Assigning to @getsentry/support for routing ⏲️

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Dec 3, 2024

@getsentry/product-owners-crons we cannot assign owners to crons programmatically from the SDK but transferring to your team on other ways to make this workflow better.

@Miradorn
Copy link
Author

Miradorn commented Dec 3, 2024

Oh damnit, I'm an idiot and opened it in the wrong repo, wanted to put it into the elixir client library.

Sorry, will reopen there!

@Miradorn Miradorn closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
@sl0thentr0py
Copy link
Member

@Miradorn you did open it in the elixir library, I moved it here because we cannot do what you asked for from the SDK.

@Miradorn Miradorn reopened this Dec 3, 2024
@Miradorn
Copy link
Author

Miradorn commented Dec 3, 2024

oh, sorry my bad.
I was under the impressien that it should already be able to be implemented due to this docs about the monitor_config: https://develop.sentry.dev/sdk/telemetry/check-ins/

@sl0thentr0py
Copy link
Member

oh.. well then my bad :)
Seems we added that recently, moving this back then and yes, we can add that then!
Apologies for the ping pong.

@sl0thentr0py
Copy link
Member

@savhappy @solnic can one of you add the owner field to check ins and expose it in the api too?

@savhappy
Copy link
Collaborator

savhappy commented Dec 3, 2024

@sl0thentr0py yep, I have some time later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants