Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for disabling request body send, or remove by default #248

Closed
bpicolo opened this issue Jun 9, 2020 · 2 comments
Closed

Add options for disabling request body send, or remove by default #248

bpicolo opened this issue Jun 9, 2020 · 2 comments

Comments

@bpicolo
Copy link

bpicolo commented Jun 9, 2020

Summary

Sentry-go currently attached request bodies by default when middleware is used, which looks to have been added in #84 . Request bodies tend to include a variety of data that are covered both by internal security policies surrounding PII, as well as various legal frameworks, e.g. GDPR, CCPA.

I don't currently see a built-in option exposed for disabling this, other than custom event processors. Am I missing that option?

Otherwise, is this something that could/should be added?

Expected Behavior

A simple option to disable request body sending, as well as warnings in documentation, would be helpful in the client. Removing them by default is probably a secure-by-default ideal, but I realize many existing users probably depend on it, and expect it from a sentry client

Edit: I see now that SendDefaultPii is probably the modern sentry param for this: https://docs.sentry.io/error-reporting/configuration/?platform=go#send-default-pii

This request should probably be to support that, then?

@bpicolo bpicolo changed the title Disable body logging by default Add options for disabling request body send, or remove by default Jun 9, 2020
@rhcarvalho
Copy link
Contributor

@bpicolo thanks for reporting. I'm closing this as a duplicate of #175.

@rhcarvalho
Copy link
Contributor

I don't currently see a built-in option exposed for disabling this, other than custom event processors. Am I missing that option?

The no-PII-by-default is something that has not been implemented yet for the Go SDK.

You are spot on on using an event processor or BeforeSend to alter events before they hit the network. Sentry also offers server-side data scrubbing, for more info please refer to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants