Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more control by overriding http.Client or http.RoundTripper #62

Closed
yansal opened this issue Sep 30, 2019 · 2 comments · Fixed by #86
Closed

Give more control by overriding http.Client or http.RoundTripper #62

yansal opened this issue Sep 30, 2019 · 2 comments · Fixed by #86

Comments

@yansal
Copy link

yansal commented Sep 30, 2019

This issue is a feature request.

It's possible to override the http.Transport via the HTTPTransport field in ClientOptions.

Instead, it would be great to allow to override the http.Client, or http.RoundTripper (which is an abstract http.Transport). This feature would allow users of this package to add hooks at the http level.

@kamilogorek
Copy link
Contributor

Hey, thanks for the patience. I've scheduled some time for patches/features and releasing a new version of sentry-go this and next week. I'll make sure to fix all the remaining issues till the EOD next week. Cheers!

@kamilogorek
Copy link
Contributor

@yansal done. Will release new tag soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants