Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.Request be changed to interface to avoid extra conversion for fasthtttp or hertz. #757

Open
li-jin-gou opened this issue Jan 6, 2024 · 0 comments

Comments

@li-jin-gou
Copy link

Summary

Hertz has a lot of users currently using sentry, some of them are sensitive to interface latency, we found that sentry-go only supports setting http.Request but not hertz's Request, and we need an additional conversion.

Motivation

If it can be changed to interface, we can remove this conversion, bringing latency and CPU performance gains.
It may not be an interface, or there may be other options that don't require the conversion of http.Request.

Additional Context

@li-jin-gou li-jin-gou changed the title Can http.Request be changed to interface to avoid extra conversion for fasthtttp or hertz. http.Request be changed to interface to avoid extra conversion for fasthtttp or hertz. Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants