Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Add request mode sessions to http instrumentation #11320

Closed
Tracked by #9508
AbhiPrasad opened this issue Mar 27, 2024 · 2 comments
Closed
Tracked by #9508

[v8] Add request mode sessions to http instrumentation #11320

AbhiPrasad opened this issue Mar 27, 2024 · 2 comments
Labels
Package: node Issues related to the Sentry Node SDK

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Mar 27, 2024 •
edited
Loading

we start & end the session in requestHook/responseHook
@AbhiPrasad AbhiPrasad mentioned this issue Mar 27, 2024
Closed
@AbhiPrasad AbhiPrasad added the Package: node Issues related to the Sentry Node SDK label Mar 27, 2024
@lforst
Copy link
Member

lforst commented Mar 27, 2024

Me and @mydea noticed that it would be very good to keep the http integration as slim as possible in the case where frameworks add their own http integration. In nextjs for example we had to remove our http integration because we could not remove Nextjs'.

@AbhiPrasad AbhiPrasad changed the title Add request mode sessions to OTEL http instrumentation [v8] Add request mode sessions to http instrumentation Mar 27, 2024
@mydea
Copy link
Member

mydea commented Apr 3, 2024

it actually works!

@mydea mydea closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: node Issues related to the Sentry Node SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mydea @lforst @AbhiPrasad