-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @sentry/google-cloud-serverless
ESM compat
#11776
Comments
@AbhiPrasad is this specifically when bundling to an ESM output, or even when bundling ESM -> CJS? I'm asking as I just tried updating my companies repo to Sentry v8, and although we are still bundling and having our GCP functions run in CJS "mode", we are unable to use the new I understand wanting to avoid supporting ESM imports to prevent people from thinking this works when executing via ESM - I presume that's the main problem, but just wanting to know the full picture if possible! Also, is there an ETA (or at least a plan) for supporting ESM? Just wondering what priority this is at internally at Sentry! |
The code we ship in our Is the ask here to also provide an ESM ( |
We can do this, but add the caveat that performance instrumentation is only supported for CJS. I can make the change! |
The serverless SDKs use
require
to monkeypatch GCP related libraries. This does not work with ESM (and it gets even more complicated with bundling).Currently we only emit an CJS bundle for serverless.
The text was updated successfully, but these errors were encountered: