Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of way too long (tens of hours) replays #13778

Closed
3 tasks done
alimony opened this issue Sep 24, 2024 · 9 comments
Closed
3 tasks done

Lots of way too long (tens of hours) replays #13778

alimony opened this issue Sep 24, 2024 · 9 comments
Assignees
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK Package: replay Issues related to the Sentry Replay SDK

Comments

@alimony
Copy link

alimony commented Sep 24, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/nextjs

SDK Version

8.25.0

Framework Version

Next 14.2.12

Link to Sentry event

[redacted]

Reproduction Example/SDK Setup

Sentry.init({
  dsn: process.env.NEXT_PUBLIC_SENTRY_DSN,
  release: process.env.NEXT_PUBLIC_SENTRY_RELEASE,
  environment: djangoEnv,
  tracesSampleRate: 1.0,
  replaysOnErrorSampleRate: 1.0,
  replaysSessionSampleRate: 1.0,
  tracePropagationTargets: djangoBackendUrls,
  integrations: [
    Sentry.browserTracingIntegration(),
    Sentry.replayIntegration({
      maskAllText: false,
      blockAllMedia: false,
      maskAllInputs: false,
      networkDetailAllowUrls: djangoBackendUrls,
    }),
  ],
  beforeSend: (event, hint) => {
    console.error(hint.originalException ?? hint.syntheticException);

    if (process.env.NEXT_PUBLIC_SENTRY_DSN) {
      return event;
    } else {
      // drop the event
      return null;
    }
  },
  beforeBreadcrumb: (breadcrumb, hint) => excludeGraphQLFetch(breadcrumb, hint),
});

Steps to Reproduce

We just see these come in all the time. This is a list of replays logged in the last seven days, ordered by duration. As you can see, some are almost 100 hours long:

Image

Also, the replays themselves just show our loading screen for the entire replay.

Expected Result

All replays should be under an hour, and show normal activity.

Actual Result

See above.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Sep 24, 2024
@github-actions github-actions bot added the Package: nextjs Issues related to the Sentry Nextjs SDK label Sep 24, 2024
@chargome chargome self-assigned this Sep 25, 2024
@Lms24
Copy link
Member

Lms24 commented Sep 26, 2024

Hi, thanks for reporting! we'll take a look

@alimony
Copy link
Author

alimony commented Oct 4, 2024

Just noting here that I'm upgrading to 8.33.x today and will report back whether #13815 seems to fix the issue or not.

@billyvg
Copy link
Member

billyvg commented Oct 4, 2024

@alimony It's unlikely to fix your issue, i believe the actual problem is #13872

@billyvg
Copy link
Member

billyvg commented Oct 17, 2024

@alimony Can you upgrade to 8.34.0 and see if this fixes your issue?

@billyvg billyvg added the Package: replay Issues related to the Sentry Replay SDK label Oct 17, 2024
@alimony
Copy link
Author

alimony commented Oct 17, 2024

@billyvg I upgraded to 8.34.0 right at release, and I'm still seeing a few of these (three times in the past few days, one 1+ hour replay, one 2+ hours, and one 4+ hours). My sense is that it's fewer of them, and not the extremely long ones, but seems to be not 100% solved yet. I will monitor more.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 17, 2024
@chargome
Copy link
Member

@alimony thanks for the update! I just checked on your replay list and it seems there are only 4 replays left that exceed one hour in the last week – and it always seems to follow the same pattern that the replayId seems to be connected to a backend error that happened much later. We'll see if there is anything else we can find, please let us know if the issue persists in the upcoming days.

@billyvg
Copy link
Member

billyvg commented Nov 13, 2024

@chargome Looks like this is still happening because #13893 only removed from DSC when replay is stopped by calling replay.stop(). There is still the case where replay should be expired, but an event hasn't happened to trigger it's expiry, and when it does happen, we simply return the event instead of resetting replay_id on DSC.

@billyvg
Copy link
Member

billyvg commented Dec 5, 2024

@alimony Can you update the SDK to the latest and see if this improves?

@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 3 Dec 10, 2024
@billyvg
Copy link
Member

billyvg commented Dec 10, 2024

This should be fixed now, please open a new issue if you're still having problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK Package: replay Issues related to the Sentry Replay SDK
Projects
Archived in project
Development

No branches or pull requests

4 participants