[Windows] `TypeError` when running Next.js app with middleware and latest @sentry/nextjs package #6858

josh- · 2023-01-19T03:31:50Z

Is there an existing issue for this?

I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
I have reviewed the documentation https://docs.sentry.io/
I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/angular

SDK Version

7.31.1

Framework Version

@sentry/nextjs 7.31.1

Link to Sentry event

https://sentry.io/organizations/triton-digital-canada-inc/issues/3883394829/

SDK Setup

The sample repro repository uses the following values, where the error still occurs.

sentry.client.config.js:

Sentry.init({
  dsn: null,
  // Adjust this value in production, or use tracesSampler for greater control
  tracesSampleRate: 1.0,
  // ...
  // Note: if you want to override the automatic release value, do not set a
  // `release` value here - use the environment variable `SENTRY_RELEASE`, so
  // that it will also get attached to your source maps
});

sentry.client.edge.js:

Sentry.init({
  dsn: null,
  // Adjust this value in production, or use tracesSampler for greater control
  tracesSampleRate: 1.0,
  // ...
  // Note: if you want to override the automatic release value, do not set a
  // `release` value here - use the environment variable `SENTRY_RELEASE`, so
  // that it will also get attached to your source maps
});

sentry.client.server.js:

Sentry.init({
  dsn: null,
  // Adjust this value in production, or use tracesSampler for greater control
  tracesSampleRate: 1.0,
  // ...
  // Note: if you want to override the automatic release value, do not set a
  // `release` value here - use the environment variable `SENTRY_RELEASE`, so
  // that it will also get attached to your source maps
});

Steps to Reproduce

Running on Windows, clone this repository which is a reproduction of the issue
Run yarn install
Run yarn dev
Browse to http://localhost:3000
Observe an error on-screen and in your terminal

Expected Result

Page is rendered successfully.

Actual Result

This could be related to #6771? (cc @lforst)

Confirmed that it works as expected with v7.29.0

The text was updated successfully, but these errors were encountered:

josh- · 2023-01-19T03:53:42Z

Have confirmed that this issue is still present when the middleware.ts and pages directory is in the root folder too (as opposed to the src directory in the reproduction sample app)

lforst · 2023-01-19T10:59:30Z

@josh- That looks super fishy. Can you try deleting your .next folder and rebuilding the project or running dev mode agin? Thanks!

lforst · 2023-01-19T11:00:47Z

Also just want to make sure you called your config files the following:

sentry.client.config.js
sentry.edge.config.js
sentry.server.config.js

and not

sentry.client.config.js
sentry.client.edge.js
sentry.client.server.js

josh- · 2023-01-19T12:02:21Z

@josh- That looks super fishy. Can you try deleting your .next folder and rebuilding the project or running dev mode agin? Thanks!

Yep, same result:

PS C:\Users\Josh\Desktop\windows-next-sentry-middleware-repro> Remove-Item -Path .\.next\ -Recurse
PS C:\Users\Josh\Desktop\windows-next-sentry-middleware-repro> yarn dev
yarn run v1.22.19
$ next dev
ready - started server on 0.0.0.0:3000, url: http://localhost:3000
event - compiled client and server successfully in 2.7s (383 modules)
wait  - compiling /middleware (client and server)...
event - compiled successfully in 1200 ms (344 modules)
wait  - compiling /_error (client and server)...
error - sentry-wrapper-module (31:0) @ <unknown>
error - _sentry_nextjs__WEBPACK_IMPORTED_MODULE_1__.wrapMiddlewareWithSentry is not a function
  29 | 
  30 | const middleware = userProvidedNamedHandler
> 31 |   ? Sentry.wrapMiddlewareWithSentry(userProvidedNamedHandler)
  32 |   : undefined;
  33 | const middlewareWrapperTemplate = userProvidedDefaultHandler ? Sentry.wrapMiddlewareWithSentry(userProvidedDefaultHandler) : undefined;
  34 | 
error - sentry-wrapper-module (31:0) @ <unknown>
error - _sentry_nextjs__WEBPACK_IMPORTED_MODULE_1__.wrapMiddlewareWithSentry is not a function
  29 | 
  30 | const middleware = userProvidedNamedHandler
> 31 |   ? Sentry.wrapMiddlewareWithSentry(userProvidedNamedHandler)
  32 |   : undefined;
  33 | const middlewareWrapperTemplate = userProvidedDefaultHandler ? Sentry.wrapMiddlewareWithSentry(userProvidedDefaultHandler) : undefined;
  34 | 
error - sentry-wrapper-module (31:0) @ <unknown>

We've also been able to reproduce this on several different windows machines who are cloning the issue reproduction repository fresh (and in our internal app where we initially ran into this)

josh- · 2023-01-19T12:04:04Z

Also just want to make sure you called your config files the following:

sentry.client.config.js

sentry.edge.config.js

sentry.server.config.js

and not

sentry.client.config.js

sentry.client.edge.js

sentry.client.server.js

Can confirm they are named correctly in the issue reproduction repository (and also our internal app):

PS C:\Users\Josh\Desktop\windows-next-sentry-middleware-repro> Get-ChildItem -Path $path -Filter "*sentry*"


    Directory: C:\Users\Josh\Desktop\windows-next-sentry-middleware-repro


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        19/01/2023   2:14 PM            613 sentry.client.config.js
-a----        19/01/2023   2:14 PM            640 sentry.edge.config.js
-a----        19/01/2023   2:14 PM            621 sentry.server.config.js

lforst · 2023-01-19T12:21:57Z

Ah sorry took me way longer to understand this issue happens on windows than it should have 😬 We'll look into it!

lforst · 2023-01-19T12:42:49Z

@josh- Weird ask but can you try replacing line 71 in node_modules/@sentry/nextjs/cjs/config/webpack.js like the following:

- test: /node_modules\/@sentry\/nextjs/,
+ test: /node_modules[\/\\]@sentry[\/\\]nextjs/,

and try building your project again? Thank you!

memmen · 2023-01-19T18:11:54Z

@josh- Weird ask but can you try replacing line 71 in node_modules/@sentry/nextjs/cjs/config/webpack.js like the following:
- test: /node_modules\/@sentry\/nextjs/,
+ test: /node_modules[\/\\]@sentry[\/\\]nextjs/,
and try building your project again? Thank you!

I had this error

error - sentry-wrapper-module (33:5) @ <unknown>
error - _sentry_nextjs__WEBPACK_IMPORTED_MODULE_1__.wrapMiddlewareWithSentry is not a function
  31 |   ? Sentry.wrapMiddlewareWithSentry(userProvidedNamedHandler)
  32 |   : undefined;
> 33 | const middlewareWrapperTemplate = userProvidedDefaultHandler ? Sentry.wrapMiddlewareWithSentry(userProvidedDefaultHandler) : undefined;
     |     ^
  34 |
  35 | export { middlewareWrapperTemplate as default, middleware };

This fixed the issue.

josh- · 2023-01-19T20:44:00Z

Thanks @lforst 👍 Confirming also this fixes the issue.

lforst · 2023-01-19T21:16:24Z

Thanks for confirming @memmen @josh-! We have a fix on its way. It will probably come with a new version on Monday. We avoid releasing on Fridays and Thursdays because we don't like working on the Weekends and all in case there is something going wrong badly.

I recommend downgrading to 7.29.0 until then!

memmen · 2023-01-19T21:17:59Z

Geczy · 2023-01-20T13:53:43Z

came here for the same issue. i fixed it by disabling middleware instrumentation on dev

  sentry: {
    autoInstrumentMiddleware: !!(
      process.env.SENTRY_DSN || process.env.NEXT_PUBLIC_SENTRY_DSN
    ),
    disableServerWebpackPlugin:
      !process.env.SENTRY_DSN && !process.env.NEXT_PUBLIC_SENTRY_DSN,
    disableClientWebpackPlugin:
      !process.env.SENTRY_DSN && !process.env.NEXT_PUBLIC_SENTRY_DSN,

    hideSourceMaps: true,
  },

lukevella · 2023-01-23T11:27:33Z

I'm still seeing this error using 7.32.0 on paths that match my middleware config. I'm using a Mac too so doesn't seem to be specific to Windows.

Here's my repo: https://github.com/lukevella/rallly/tree/update-sentry

lforst · 2023-01-23T15:27:59Z

@lukevella Thanks for providing that repo! It helped identifying a regression in the last release. We are in the process of releasing a patch with a fix.

Side-note: Sorry about all these issues with the SDK. We're doing some pretty ambitious stuff to support every feature and it's gotten a little bit fragile. I hope it won't take too long to mature!

wadehammes · 2023-01-23T15:41:26Z

Will this next patch fix an error I am seeing with latest version (and does this relate to the above)? Getting this with 7.32.0:

Attempted import error: 'wrapMiddlewareWithSentry' is not exported from '@sentry/nextjs' (imported as 'Sentry')

Currently causing Vercel builds to fail. Can open a new issue if this doesn't relate to this.

lforst · 2023-01-23T15:54:06Z

Will this next patch fix an error I am seeing with latest version (and does this relate to the above)? Getting this with 7.32.0:

Attempted import error: 'wrapMiddlewareWithSentry' is not exported from '@sentry/nextjs' (imported as 'Sentry')

Currently causing Vercel builds to fail. Can open a new issue if this doesn't relate to this.

@wadehammes Yeah that should be fixed with version 7.32.1. Let me know if upgrading resolves this issue for you.

lukevella · 2023-01-23T16:03:47Z

I can confirm that this issue seems to be fixed in 7.32.1. Thanks for the quick turnaround 👍

lforst · 2023-01-23T16:07:16Z

I can confirm that this issue seems to be fixed in 7.32.1. Thanks for the quick turnaround 👍

@lukevella Thanks for checking!

wadehammes · 2023-01-23T16:16:19Z

@lforst also confirm that the error I was experiencing is fixed in latest

josh- added the Type: Bug label Jan 19, 2023

getsantry bot added the Status: Untriaged label Jan 19, 2023

lforst added Status: Needs Information Package: nextjs Issues related to the Sentry Nextjs SDK and removed Status: Untriaged labels Jan 19, 2023

lforst changed the title ~~TypeError when running Next.js app with middleware and latest @sentry/nextjs package~~ [Windows] TypeError when running Next.js app with middleware and latest @sentry/nextjs package Jan 19, 2023

lforst mentioned this issue Jan 19, 2023

fix(nextjs): Fix SDK multiplexer loader on Windows #6866

Merged

lforst closed this as completed in #6866 Jan 19, 2023

lforst self-assigned this Jan 19, 2023

facundocastello mentioned this issue Jun 28, 2023

TypeError when running Next.js app with middleware and latest @sentry/nextjs package #8416

Closed

3 tasks

naofalleoagusta mentioned this issue Jul 12, 2023

Unable to setUser on Next.js middleware + next-auth #8508

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Windows] `TypeError` when running Next.js app with middleware and latest @sentry/nextjs package #6858

[Windows] `TypeError` when running Next.js app with middleware and latest @sentry/nextjs package #6858

josh- commented Jan 19, 2023 •

edited

Loading

josh- commented Jan 19, 2023

lforst commented Jan 19, 2023

lforst commented Jan 19, 2023

josh- commented Jan 19, 2023

josh- commented Jan 19, 2023

lforst commented Jan 19, 2023

lforst commented Jan 19, 2023

memmen commented Jan 19, 2023

josh- commented Jan 19, 2023

lforst commented Jan 19, 2023

memmen commented Jan 19, 2023

Geczy commented Jan 20, 2023

lukevella commented Jan 23, 2023 •

edited

Loading

lforst commented Jan 23, 2023 •

edited

Loading

wadehammes commented Jan 23, 2023 •

edited

Loading

lforst commented Jan 23, 2023 •

edited

Loading

lukevella commented Jan 23, 2023

lforst commented Jan 23, 2023

wadehammes commented Jan 23, 2023

[Windows] TypeError when running Next.js app with middleware and latest @sentry/nextjs package #6858

[Windows] TypeError when running Next.js app with middleware and latest @sentry/nextjs package #6858

Comments

josh- commented Jan 19, 2023 • edited Loading

Is there an existing issue for this?

How do you use Sentry?

Which package are you using?

SDK Version

Framework Version

Link to Sentry event

SDK Setup

Steps to Reproduce

Expected Result

Actual Result

josh- commented Jan 19, 2023

lforst commented Jan 19, 2023

lforst commented Jan 19, 2023

josh- commented Jan 19, 2023

josh- commented Jan 19, 2023

lforst commented Jan 19, 2023

lforst commented Jan 19, 2023

memmen commented Jan 19, 2023

josh- commented Jan 19, 2023

lforst commented Jan 19, 2023

memmen commented Jan 19, 2023

Geczy commented Jan 20, 2023

lukevella commented Jan 23, 2023 • edited Loading

lforst commented Jan 23, 2023 • edited Loading

wadehammes commented Jan 23, 2023 • edited Loading

lforst commented Jan 23, 2023 • edited Loading

lukevella commented Jan 23, 2023

lforst commented Jan 23, 2023

wadehammes commented Jan 23, 2023

[Windows] `TypeError` when running Next.js app with middleware and latest @sentry/nextjs package #6858

[Windows] `TypeError` when running Next.js app with middleware and latest @sentry/nextjs package #6858

josh- commented Jan 19, 2023 •

edited

Loading

lukevella commented Jan 23, 2023 •

edited

Loading

lforst commented Jan 23, 2023 •

edited

Loading

wadehammes commented Jan 23, 2023 •

edited

Loading

lforst commented Jan 23, 2023 •

edited

Loading