feat(feedback): Configure feedback border radius #10289
Conversation
size-limit report 📦
|
packages/feedback/src/constants.ts
Outdated
| @@ -38,7 +39,10 @@ const LIGHT_THEME = { | |||
| inputBackground: INHERIT, | |||
| inputForeground: INHERIT, | |||
| inputBorder: 'var(--border)', | |||
| inputBorderRadius: '6px', | |||
There was a problem hiding this comment.
let's move/rename this to formContentBorderRadius and apply it to inputs and submit/cancel buttons - from a design POV, the children elements inside of the form should have the same border radius
| /** | ||
| * Border radius for dialog | ||
| */ | ||
| formBorderRadius: string; |
There was a problem hiding this comment.
hmm, is form clear here as a prefix (from a user pov) - meaning is it clear what this border radius is referring to?
There was a problem hiding this comment.
we use formTitle, and refer to Feedback form in the docs, so this should be clear
There was a problem hiding this comment.
We can see if @Jesse-Box can update this image for us too: https://docs.sentry.io/static/e2e105a53b6f4e5d8a8be9acb8a6ec70/07a9c/user-feedback-widget-customization.png
| /** | ||
| * Border radius for form inputs | ||
| */ | ||
| formContentBorderRadius: string; |
There was a problem hiding this comment.
not 100% sure but what about maybe inputBorderRadius or something like this?
There was a problem hiding this comment.
we considered inputBorderRadius, but this applies to the input and the buttons in the form (cancel & submit) so we wanted it to be more clear
Adds ability to configure all border radiuses on feedback widget
Closes #10256