Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Ensure replay_id is not captured when session is expired #9109

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix(replay): Ensure replay_id is not captured when session is expired #9109

merged 1 commit into from
Sep 25, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 25, 2023

Closes #9106

@mydea mydea requested a review from billyvg September 25, 2023 15:22
@mydea mydea self-assigned this Sep 25, 2023
@mydea mydea enabled auto-merge (squash) September 25, 2023 15:30
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.58 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.46 KB (0%)
@sentry/browser - Webpack (gzipped) 22.06 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.27 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.57 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.64 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 222.21 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.57 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.42 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.43 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.61 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.09 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.48 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.04 KB (0%)

@mydea mydea merged commit 618e992 into develop Sep 25, 2023
76 checks passed
@mydea mydea deleted the fn/replay-id-error branch September 25, 2023 15:43
billyvg pushed a commit that referenced this pull request Sep 26, 2023
@mydea @billyvg
fix(replay): Ensure replay_id is not captured when session is expir…
7adf5db 
…ed (#9109)

Closes #9106
@mydea mydea mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Replay] Ensure we check replay session before adding replay_id to errors
2 participants
@mydea @billyvg