Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxBreadcrumbSize to 0 crashes Android on Start #3634

Closed
6 of 11 tasks
lucas-zimerman opened this issue Feb 27, 2024 · 2 comments · Fixed by #4266
Closed
6 of 11 tasks

MaxBreadcrumbSize to 0 crashes Android on Start #3634

lucas-zimerman opened this issue Feb 27, 2024 · 2 comments · Fixed by #4266

Comments

@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented Feb 27, 2024

🔴 Waiting for

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 0.0.0

react-native version: 0.0.0

Are you using Expo?

  • Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

[Link to issue]

Configuration:

(@sentry/react-native)

Sentry.init({
  // Replace the example DSN below with your own DSN:
  dsn: SENTRY_INTERNAL_DSN,
  debug: true,
  environment: 'dev',
  maxBreadcrumbs: 0,
 ...
});

I have the following issue:

If you set maxBreadcrumbs: 0, the app will crash when opened. it's not mentioned that the size 0 will not work on the docs but if I recall it worked on other SDK that I worked in the past.

Steps to reproduce:

  • Step 1
  • maxBreadcrumbs: 0 on SentryOptions
  • Step 2
  • Open the app

Actual result:

image

Expected result:

The app to not crash and have events without breadcrumbs.

@krystofwoldrich
Copy link
Member

Two items to fix, pass a valid value to sentry-android and ensure that no breadcrumbs are added in JS.

We might need to fix/check sentry-java to allow 0.

@krystofwoldrich krystofwoldrich moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 8, 2024
@lucas-zimerman lucas-zimerman moved this from Backlog to In Progress in Mobile & Cross Platform SDK Apr 9, 2024
@lucas-zimerman
Copy link
Collaborator Author

Related: getsentry/sentry-java#3313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants