Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails: allow showing link to sentry page on error page #1846

Closed
grosser opened this issue Jul 13, 2022 · 8 comments · Fixed by #1849
Closed

rails: allow showing link to sentry page on error page #1846

grosser opened this issue Jul 13, 2022 · 8 comments · Fixed by #1849

Comments

@grosser
Copy link

grosser commented Jul 13, 2022

Describe the idea
image

Why do you think it's beneficial to most of the users

  • useful for internal apps to be able to link directly to the error
  • useful for public apps to show an error code that engineers can later hunt down

Possible implementation
https://github.com/grosser/sentry-user_informer

@st0012
Copy link
Collaborator

st0012 commented Jul 19, 2022

I like the idea but I'm not sure if we need to use Fiber locals for that. Won't storing it in env work?

@grosser
Copy link
Author

grosser commented Jul 19, 2022

storing in env will work if the core middleware is refactored to pass the env to capture_exception

@st0012
Copy link
Collaborator

st0012 commented Jul 19, 2022

I just did it in #1847 😄

@grosser
Copy link
Author

grosser commented Jul 19, 2022

awesome ... so do you want to add this feature too then ?

@st0012
Copy link
Collaborator

st0012 commented Jul 20, 2022

I'm not convinced that we should maintain a new middleware + a template (even just minimum) for this. I think as an SDK, it should just inject the event id into the env and users/libraries should implement their solutions from there.

@grosser
Copy link
Author

grosser commented Jul 20, 2022

I'm fine with that too, good step forward and easy to do ...

@st0012 st0012 added this to the 5.4.0 milestone Jul 20, 2022
@st0012
Copy link
Collaborator

st0012 commented Jul 20, 2022

Ok I’ll open a PR for that 👍

@st0012
Copy link
Collaborator

st0012 commented Jul 20, 2022

PR opened: #1849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants