Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release name shouldn't include invalid characters #382

Closed
bruno-garcia opened this issue Oct 21, 2021 · 2 comments · Fixed by #389
Closed

Release name shouldn't include invalid characters #382

bruno-garcia opened this issue Oct 21, 2021 · 2 comments · Fixed by #389
Labels
Bug Something isn't working

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 21, 2021

while building Sentry Defenses I notice we append an app name that could contain spaces:

@"release" : @"Sentry Defenses@1.0.1",

We should Regex.Replace any character not valid on the left side of @ with _

Docs state that only invalid characters are:

The release name cannot:

contain newlines, tabulator characters, forward slashes(/) or back slashes()
be (in their entirety) period (.), double period (..), or space ( )
exceed 200 characters

Confirm these (space is OK?) and do the proper validation as specified

@bruno-garcia bruno-garcia added the Bug Something isn't working label Oct 21, 2021
@bruno-garcia
Copy link
Member Author

image

The space seems OK. But somehow it changed from io.sentry.game.defenses to Sentry Defenses

@bitsandfoxes
Copy link
Contributor

image

The space seems OK. But somehow it changed from io.sentry.game.defenses to Sentry Defenses

You renamed it to Sentry Defenses when you added an icon and the splashscreen: getsentry/sentry-defenses@05b1861#diff-1d4e39902f0b80b0d8badcf7818305afb5b0b31eb8736fba7e17bbaee2da2e8aL16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants