From 8f9714f7227b72b97c2ff8d8f50ee870e5344ca7 Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Fri, 7 Jun 2024 11:52:22 +0200 Subject: [PATCH 1/2] Downgrade and pin `zip` to fix SourceBundles with >64k files The recent symbolicator update started emitting errors related to this. After a short debugging sessions, I pinned down the problem to a regression in `zip` which broke archives with >64k files. --- Cargo.lock | 4 ++-- Cargo.toml | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index aa6140a5..9a78d675 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2976,9 +2976,9 @@ dependencies = [ [[package]] name = "zip" -version = "2.1.2" +version = "2.1.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "098d5d7737fb0b70814faa73c17df84f047d38dd31d13bbf2ec3fb354b5abf45" +checksum = "1dd56a4d5921bc2f99947ac5b3abe5f510b1be7376fdc5e9fce4a23c6a93e87c" dependencies = [ "arbitrary", "crc32fast", diff --git a/Cargo.toml b/Cargo.toml index df5ba9b4..e8f9c20a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -62,7 +62,8 @@ uuid = "1.3.0" walkdir = "2.3.1" wasmparser = "0.209.1" watto = { version = "0.1.0", features = ["writer", "strings"] } -zip = { version = "2.1.2", default-features = false, features = ["deflate"] } +# We are currently pinning a known good version prior to https://github.com/zip-rs/zip2/issues/189 +zip = { version = "=2.1.1", default-features = false, features = ["deflate"] } zstd = { version = "0.13.1" } From 1b36f21e5a1d1483f0b41d03a6205dcf9a1aa8ee Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Fri, 7 Jun 2024 11:56:39 +0200 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c75456b5..381faaaf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## Unreleased + +- Downgrade and pin `zip` to fix SourceBundles with >64k files ([#846](https://github.com/getsentry/symbolic/pull/846)) + ## 12.9.1 **Features**