From 22ed613ccf1425982a3703cc6f514b802c5df8c6 Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Wed, 13 Sep 2023 12:22:43 +0200 Subject: [PATCH] Only write cache metadata on debug builds This should cut the number of files that are written on production builds in half, reducing pressure on the cleanup job. --- crates/symbolicator-service/src/caching/memory.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/crates/symbolicator-service/src/caching/memory.rs b/crates/symbolicator-service/src/caching/memory.rs index c7cb53b39..e141e9ca7 100644 --- a/crates/symbolicator-service/src/caching/memory.rs +++ b/crates/symbolicator-service/src/caching/memory.rs @@ -251,10 +251,13 @@ impl Cacher { persist_tempfile(temp_file, &cache_path)?; - // NOTE: we only create the metadata file once, but do not regularly touch it for now - cache_path.set_extension("txt"); - if let Err(err) = std::fs::write(cache_path, key.metadata()) { - tracing::error!(error = &err as &dyn std::error::Error); + #[cfg(debug_assertions)] + { + // NOTE: we only create the metadata file once, but do not regularly touch it for now + cache_path.set_extension("txt"); + if let Err(err) = std::fs::write(cache_path, key.metadata()) { + tracing::error!(error = &err as &dyn std::error::Error); + } } };