From c3e735c5d59c3a80a701bf52e44df7f96dea1dde Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Fri, 29 Sep 2023 16:44:29 +0200 Subject: [PATCH] Add a metric for needed files per JS event --- crates/symbolicator-service/src/js/metrics.rs | 2 ++ crates/symbolicator-service/src/services/sourcemap_lookup.rs | 2 ++ 2 files changed, 4 insertions(+) diff --git a/crates/symbolicator-service/src/js/metrics.rs b/crates/symbolicator-service/src/js/metrics.rs index b13bcec20..913767835 100644 --- a/crates/symbolicator-service/src/js/metrics.rs +++ b/crates/symbolicator-service/src/js/metrics.rs @@ -5,6 +5,7 @@ use crate::types::ResolvedWith; /// Various metrics we want to capture *per-event* for JS events. #[derive(Debug, Default)] pub struct JsMetrics { + pub needed_files: u64, pub api_requests: u64, pub queried_artifacts: u64, pub fetched_artifacts: u64, @@ -87,6 +88,7 @@ impl JsMetrics { } pub fn submit_metrics(&self, artifact_bundles: u64) { + metric!(time_raw("js.needed_files") = self.needed_files); metric!(time_raw("js.api_requests") = self.api_requests); metric!(time_raw("js.queried_bundles") = self.queried_bundles); metric!(time_raw("js.fetched_bundles") = artifact_bundles); diff --git a/crates/symbolicator-service/src/services/sourcemap_lookup.rs b/crates/symbolicator-service/src/services/sourcemap_lookup.rs index 0b67359ad..ac71de938 100644 --- a/crates/symbolicator-service/src/services/sourcemap_lookup.rs +++ b/crates/symbolicator-service/src/services/sourcemap_lookup.rs @@ -723,6 +723,8 @@ impl ArtifactFetcher { /// (because multiple files can share one [`DebugId`]). #[tracing::instrument(skip(self))] pub async fn get_file(&mut self, key: &FileKey) -> CachedFileEntry { + self.metrics.needed_files += 1; + let mut file = self.try_get_file_using_index(key).await; if file.is_none() {