From 3685519fee06aa00d64905eea5b923c9d74fb3c3 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 11:37:14 -0400 Subject: [PATCH 01/12] lets start on universal builds --- .github/workflows/build.yml | 144 ++++++++++++++++++------------------ 1 file changed, 73 insertions(+), 71 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 95da16944..fa23d564f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -4,48 +4,50 @@ on: push: branches: - release/** + # Temp + - macos_universal_ci_release jobs: - linux: - name: Build Binary on Linux - runs-on: ubuntu-latest - - steps: - - name: Checkout sources - uses: actions/checkout@v2 - - - name: Install rust stable toolchain - uses: actions-rs/toolchain@v1 - with: - toolchain: stable - profile: minimal - override: true - - - name: Run cargo build - uses: actions-rs/cargo@v1 - with: - command: build - args: --all --release --locked - - - name: Split and archive debug info - run: | - mkdir -p build - - # Split only symbolicator's debug information - objcopy --only-keep-debug target/release/symbolicator{,.debug} - objcopy --strip-debug --strip-unneeded target/release/symbolicator - objcopy --add-gnu-debuglink target/release/symbolicator{.debug,} - zip -j build/symbolicator-Linux-x86_64-debug.zip target/release/symbolicator.debug - - # Move all binaries - mv target/release/symbolicator build/symbolicator-Linux-x86_64 - mv target/release/wasm-split build/wasm-split-Linux-x86_64 - mv target/release/symsorter build/symsorter-Linux-x86_64 - - - uses: actions/upload-artifact@v2 - with: - name: ${{ github.sha }} - path: build/* + # linux: + # name: Build Binary on Linux + # runs-on: ubuntu-latest + + # steps: + # - name: Checkout sources + # uses: actions/checkout@v2 + + # - name: Install rust stable toolchain + # uses: actions-rs/toolchain@v1 + # with: + # toolchain: stable + # profile: minimal + # override: true + + # - name: Run cargo build + # uses: actions-rs/cargo@v1 + # with: + # command: build + # args: --all --release --locked + + # - name: Split and archive debug info + # run: | + # mkdir -p build + + # # Split only symbolicator's debug information + # objcopy --only-keep-debug target/release/symbolicator{,.debug} + # objcopy --strip-debug --strip-unneeded target/release/symbolicator + # objcopy --add-gnu-debuglink target/release/symbolicator{.debug,} + # zip -j build/symbolicator-Linux-x86_64-debug.zip target/release/symbolicator.debug + + # # Move all binaries + # mv target/release/symbolicator build/symbolicator-Linux-x86_64 + # mv target/release/wasm-split build/wasm-split-Linux-x86_64 + # mv target/release/symsorter build/symsorter-Linux-x86_64 + + # - uses: actions/upload-artifact@v2 + # with: + # name: ${{ github.sha }} + # path: build/* mac: name: Build Binary on MacOS @@ -84,34 +86,34 @@ jobs: cd target/release zip -r ../../build/symbolicator-Darwin-x86_64-debug.zip symbolicator.dSYM - - uses: actions/upload-artifact@v2 - with: - name: ${{ github.sha }} - path: build/* - - docs: - name: Build Docs - runs-on: ubuntu-latest - - steps: - - name: Checkout sources - uses: actions/checkout@v2 - - - name: Setup Python - uses: actions/setup-python@v2 - with: - python-version: 3.8 - - - name: Setup python dependencies - run: pip install --upgrade mkdocs mkdocs-material pygments - - - name: Build Docs - run: | - mkdocs build - touch site/.nojekyll - cd site && zip -r gh-pages . - - - uses: actions/upload-artifact@v2 - with: - name: ${{ github.sha }} - path: site/gh-pages.zip + # - uses: actions/upload-artifact@v2 + # with: + # name: ${{ github.sha }} + # path: build/* + + # docs: + # name: Build Docs + # runs-on: ubuntu-latest + + # steps: + # - name: Checkout sources + # uses: actions/checkout@v2 + + # - name: Setup Python + # uses: actions/setup-python@v2 + # with: + # python-version: 3.8 + + # - name: Setup python dependencies + # run: pip install --upgrade mkdocs mkdocs-material pygments + + # - name: Build Docs + # run: | + # mkdocs build + # touch site/.nojekyll + # cd site && zip -r gh-pages . + + # - uses: actions/upload-artifact@v2 + # with: + # name: ${{ github.sha }} + # path: site/gh-pages.zip From c9eb957821e0671d9c5d646877e61eff7ef1a1df Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 11:39:55 -0400 Subject: [PATCH 02/12] run on PR --- .github/workflows/build.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fa23d564f..02c80cc26 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -4,8 +4,9 @@ on: push: branches: - release/** - # Temp - - macos_universal_ci_release + + # Temp + pull_request: jobs: # linux: From a51168ce1cd473a8b8d7b018651b16aaa303cec1 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 11:40:40 -0400 Subject: [PATCH 03/12] try latest macos --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 02c80cc26..3cbd518c9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -52,7 +52,7 @@ jobs: mac: name: Build Binary on MacOS - runs-on: macos-10.15 + runs-on: macos-11 steps: - name: Checkout sources From 343b58704c12472ced1e66cc2f679cd43e0fd2e1 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 12:16:41 -0400 Subject: [PATCH 04/12] try arm build --- .github/workflows/build.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3cbd518c9..4ee9c074a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -64,6 +64,7 @@ jobs: toolchain: stable profile: minimal override: true + target: aarch64-apple-darwin - name: Run cargo build uses: actions-rs/cargo@v1 @@ -72,20 +73,20 @@ jobs: CARGO_PROFILE_RELEASE_SPLIT_DEBUGINFO: packed with: command: build - args: --all --release --locked + args: --all --release --locked --target=aarch64-apple-darwin - name: Archive debug info run: | mkdir -p build # Move all binaries to output directory - mv target/release/symbolicator build/symbolicator-Darwin-x86_64 - mv target/release/wasm-split build/wasm-split-Darwin-x86_64 - mv target/release/symsorter build/symsorter-Darwin-x86_64 + mv target/aarch64-apple-darwin/release/symbolicator build/symbolicator-Darwin-aarch64 + mv target/aarch64-apple-darwin/release/wasm-split build/wasm-split-Darwin-aarch64 + mv target/aarch64-apple-darwin/release/symsorter build/symsorter-Darwin-aarch64 # Recursive zip the debug symbol folder and place the output in the output directory cd target/release - zip -r ../../build/symbolicator-Darwin-x86_64-debug.zip symbolicator.dSYM + zip -r ../../build/symbolicator-Darwin-aarch64-debug.zip symbolicator.dSYM # - uses: actions/upload-artifact@v2 # with: From ba32b30fd3f65ce0b35dba41861c5e18db88baca Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 12:47:13 -0400 Subject: [PATCH 05/12] fix paths --- .github/workflows/build.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4ee9c074a..7f63b5032 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -79,14 +79,15 @@ jobs: run: | mkdir -p build + cd target/aarch64-apple-darwin/release + # Move all binaries to output directory - mv target/aarch64-apple-darwin/release/symbolicator build/symbolicator-Darwin-aarch64 - mv target/aarch64-apple-darwin/release/wasm-split build/wasm-split-Darwin-aarch64 - mv target/aarch64-apple-darwin/release/symsorter build/symsorter-Darwin-aarch64 + mv symbolicator ../../../build/symbolicator-Darwin-aarch64 + mv wasm-split ../../../build/wasm-split-Darwin-aarch64 + mv symsorter ../../../build/symsorter-Darwin-aarch64 # Recursive zip the debug symbol folder and place the output in the output directory - cd target/release - zip -r ../../build/symbolicator-Darwin-aarch64-debug.zip symbolicator.dSYM + zip -r ../../../build/symbolicator-Darwin-aarch64-debug.zip symbolicator.dSYM # - uses: actions/upload-artifact@v2 # with: From 17942b7048c3a665b3d8a0f090bbc5821e5e35f9 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 12:59:59 -0400 Subject: [PATCH 06/12] with matrix --- .github/workflows/build.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7f63b5032..6c1426d27 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -53,7 +53,9 @@ jobs: mac: name: Build Binary on MacOS runs-on: macos-11 - + strategy: + matrix: + target: [aarch64-apple-darwin, x86_64-apple-darwin] steps: - name: Checkout sources uses: actions/checkout@v2 @@ -64,7 +66,7 @@ jobs: toolchain: stable profile: minimal override: true - target: aarch64-apple-darwin + target: ${{ matrix.target }} - name: Run cargo build uses: actions-rs/cargo@v1 @@ -73,21 +75,21 @@ jobs: CARGO_PROFILE_RELEASE_SPLIT_DEBUGINFO: packed with: command: build - args: --all --release --locked --target=aarch64-apple-darwin + args: --all --release --locked --target=${{ matrix.target }} - name: Archive debug info run: | mkdir -p build - cd target/aarch64-apple-darwin/release + cd target/${{ matrix.target }}/release # Move all binaries to output directory - mv symbolicator ../../../build/symbolicator-Darwin-aarch64 - mv wasm-split ../../../build/wasm-split-Darwin-aarch64 - mv symsorter ../../../build/symsorter-Darwin-aarch64 + mv symbolicator ../../../build/symbolicator-${{ matrix.target }} + mv wasm-split ../../../build/wasm-split-${{ matrix.target }} + mv symsorter ../../../build/symsorter-${{ matrix.target }} # Recursive zip the debug symbol folder and place the output in the output directory - zip -r ../../../build/symbolicator-Darwin-aarch64-debug.zip symbolicator.dSYM + zip -r ../../../build/symbolicator-${{ matrix.target }}-debug.zip symbolicator.dSYM # - uses: actions/upload-artifact@v2 # with: From f9c747a30100088fac554c4d183de6d7f15b3b90 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 13:24:29 -0400 Subject: [PATCH 07/12] see if we can lipo --- .github/workflows/build.yml | 45 ++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6c1426d27..a6241d5e1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -53,9 +53,6 @@ jobs: mac: name: Build Binary on MacOS runs-on: macos-11 - strategy: - matrix: - target: [aarch64-apple-darwin, x86_64-apple-darwin] steps: - name: Checkout sources uses: actions/checkout@v2 @@ -66,30 +63,52 @@ jobs: toolchain: stable profile: minimal override: true - target: ${{ matrix.target }} + target: x86_64-apple-darwin + target: aarch64-apple-darwin - - name: Run cargo build + - name: Run cargo build x86_64 uses: actions-rs/cargo@v1 env: # Generates separate debug symbol files alongside release builds CARGO_PROFILE_RELEASE_SPLIT_DEBUGINFO: packed with: command: build - args: --all --release --locked --target=${{ matrix.target }} + args: --all --release --locked --target=x86_64-apple-darwin + + - name: Run cargo build ARM + uses: actions-rs/cargo@v1 + env: + # Generates separate debug symbol files alongside release builds + CARGO_PROFILE_RELEASE_SPLIT_DEBUGINFO: packed + with: + command: build + args: --all --release --locked --target=aarch64-apple-darwin - name: Archive debug info run: | mkdir -p build - cd target/${{ matrix.target }}/release + lipo -create -output build/symbolicator-Darwin-universal \ + target/x86_64-apple-darwin/release/symbolicator \ + target/aarch64-apple-darwin/release/symbolicator + + lipo -create -output build/wasm-split-Darwin-universal \ + target/x86_64-apple-darwin/release/wasm-split \ + target/aarch64-apple-darwin/release/wasm-split + + lipo -create -output build/symsorter-Darwin-universal \ + target/x86_64-apple-darwin/release/symsorter \ + target/aarch64-apple-darwin/release/symsorter + + # cd target/${{ matrix.target }}/release - # Move all binaries to output directory - mv symbolicator ../../../build/symbolicator-${{ matrix.target }} - mv wasm-split ../../../build/wasm-split-${{ matrix.target }} - mv symsorter ../../../build/symsorter-${{ matrix.target }} + # # Move all binaries to output directory + # mv symbolicator ../../../build/symbolicator-${{ matrix.target }} + # mv wasm-split ../../../build/wasm-split-${{ matrix.target }} + # mv symsorter ../../../build/symsorter-${{ matrix.target }} - # Recursive zip the debug symbol folder and place the output in the output directory - zip -r ../../../build/symbolicator-${{ matrix.target }}-debug.zip symbolicator.dSYM + # # Recursive zip the debug symbol folder and place the output in the output directory + # zip -r ../../../build/symbolicator-${{ matrix.target }}-debug.zip symbolicator.dSYM # - uses: actions/upload-artifact@v2 # with: From 165f3be512afc17bc56c05b890b7a542203f28e0 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 13:26:56 -0400 Subject: [PATCH 08/12] two steps --- .github/workflows/build.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a6241d5e1..a1bea6cf0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -57,14 +57,13 @@ jobs: - name: Checkout sources uses: actions/checkout@v2 - - name: Install rust stable toolchain + - name: Install rust stable toolchain x86_64 uses: actions-rs/toolchain@v1 with: toolchain: stable profile: minimal override: true target: x86_64-apple-darwin - target: aarch64-apple-darwin - name: Run cargo build x86_64 uses: actions-rs/cargo@v1 @@ -75,6 +74,14 @@ jobs: command: build args: --all --release --locked --target=x86_64-apple-darwin + - name: Install rust stable toolchain ARM + uses: actions-rs/toolchain@v1 + with: + toolchain: stable + profile: minimal + override: true + target: aarch64-apple-darwin + - name: Run cargo build ARM uses: actions-rs/cargo@v1 env: From 8c75384b0c1b0663d949bdcc7d21bb88864e93ca Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 14:57:52 -0400 Subject: [PATCH 09/12] do debug zip for both arch --- .github/workflows/build.yml | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a1bea6cf0..88b30fc33 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -51,13 +51,16 @@ jobs: # path: build/* mac: + # Note: This doesn't use a build matrix, as it requires a last step to merge the x86 + # and ARM binaries into one universal one. This need will go away once + # https://github.com/rust-lang/cargo/issues/8875 is resolved. name: Build Binary on MacOS runs-on: macos-11 steps: - name: Checkout sources uses: actions/checkout@v2 - - name: Install rust stable toolchain x86_64 + - name: Install rust stable toolchain for x86_64 uses: actions-rs/toolchain@v1 with: toolchain: stable @@ -65,7 +68,7 @@ jobs: override: true target: x86_64-apple-darwin - - name: Run cargo build x86_64 + - name: Run cargo build for x86_64 uses: actions-rs/cargo@v1 env: # Generates separate debug symbol files alongside release builds @@ -74,7 +77,7 @@ jobs: command: build args: --all --release --locked --target=x86_64-apple-darwin - - name: Install rust stable toolchain ARM + - name: Install rust stable toolchain for ARM uses: actions-rs/toolchain@v1 with: toolchain: stable @@ -82,7 +85,7 @@ jobs: override: true target: aarch64-apple-darwin - - name: Run cargo build ARM + - name: Run cargo build for ARM uses: actions-rs/cargo@v1 env: # Generates separate debug symbol files alongside release builds @@ -91,7 +94,7 @@ jobs: command: build args: --all --release --locked --target=aarch64-apple-darwin - - name: Archive debug info + - name: Archive debug info and create universal binary run: | mkdir -p build @@ -107,15 +110,13 @@ jobs: target/x86_64-apple-darwin/release/symsorter \ target/aarch64-apple-darwin/release/symsorter - # cd target/${{ matrix.target }}/release + cd target/x86_64-apple-darwin/release + # Recursive zip the debug symbol folder and place the output in the output directory + zip -r ../../../build/symbolicator-x86_64-apple-darwin-debug.zip symbolicator.dSYM + cd ../../../ - # # Move all binaries to output directory - # mv symbolicator ../../../build/symbolicator-${{ matrix.target }} - # mv wasm-split ../../../build/wasm-split-${{ matrix.target }} - # mv symsorter ../../../build/symsorter-${{ matrix.target }} - - # # Recursive zip the debug symbol folder and place the output in the output directory - # zip -r ../../../build/symbolicator-${{ matrix.target }}-debug.zip symbolicator.dSYM + cd target/x86_64-apple-darwin/release + zip -r ../../../build/symbolicator-aarch64-apple-darwin-debug.zip symbolicator.dSYM # - uses: actions/upload-artifact@v2 # with: From 1320b56929f7d119beed18ab7abe5795c822a23e Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 14:58:32 -0400 Subject: [PATCH 10/12] put everything back --- .github/workflows/build.yml | 145 ++++++++++++++++++------------------ 1 file changed, 71 insertions(+), 74 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 88b30fc33..1b483449b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -5,50 +5,47 @@ on: branches: - release/** - # Temp - pull_request: - jobs: - # linux: - # name: Build Binary on Linux - # runs-on: ubuntu-latest - - # steps: - # - name: Checkout sources - # uses: actions/checkout@v2 - - # - name: Install rust stable toolchain - # uses: actions-rs/toolchain@v1 - # with: - # toolchain: stable - # profile: minimal - # override: true - - # - name: Run cargo build - # uses: actions-rs/cargo@v1 - # with: - # command: build - # args: --all --release --locked - - # - name: Split and archive debug info - # run: | - # mkdir -p build - - # # Split only symbolicator's debug information - # objcopy --only-keep-debug target/release/symbolicator{,.debug} - # objcopy --strip-debug --strip-unneeded target/release/symbolicator - # objcopy --add-gnu-debuglink target/release/symbolicator{.debug,} - # zip -j build/symbolicator-Linux-x86_64-debug.zip target/release/symbolicator.debug - - # # Move all binaries - # mv target/release/symbolicator build/symbolicator-Linux-x86_64 - # mv target/release/wasm-split build/wasm-split-Linux-x86_64 - # mv target/release/symsorter build/symsorter-Linux-x86_64 - - # - uses: actions/upload-artifact@v2 - # with: - # name: ${{ github.sha }} - # path: build/* + linux: + name: Build Binary on Linux + runs-on: ubuntu-latest + + steps: + - name: Checkout sources + uses: actions/checkout@v2 + + - name: Install rust stable toolchain + uses: actions-rs/toolchain@v1 + with: + toolchain: stable + profile: minimal + override: true + + - name: Run cargo build + uses: actions-rs/cargo@v1 + with: + command: build + args: --all --release --locked + + - name: Split and archive debug info + run: | + mkdir -p build + + # Split only symbolicator's debug information + objcopy --only-keep-debug target/release/symbolicator{,.debug} + objcopy --strip-debug --strip-unneeded target/release/symbolicator + objcopy --add-gnu-debuglink target/release/symbolicator{.debug,} + zip -j build/symbolicator-Linux-x86_64-debug.zip target/release/symbolicator.debug + + # Move all binaries + mv target/release/symbolicator build/symbolicator-Linux-x86_64 + mv target/release/wasm-split build/wasm-split-Linux-x86_64 + mv target/release/symsorter build/symsorter-Linux-x86_64 + + - uses: actions/upload-artifact@v2 + with: + name: ${{ github.sha }} + path: build/* mac: # Note: This doesn't use a build matrix, as it requires a last step to merge the x86 @@ -118,34 +115,34 @@ jobs: cd target/x86_64-apple-darwin/release zip -r ../../../build/symbolicator-aarch64-apple-darwin-debug.zip symbolicator.dSYM - # - uses: actions/upload-artifact@v2 - # with: - # name: ${{ github.sha }} - # path: build/* - - # docs: - # name: Build Docs - # runs-on: ubuntu-latest - - # steps: - # - name: Checkout sources - # uses: actions/checkout@v2 - - # - name: Setup Python - # uses: actions/setup-python@v2 - # with: - # python-version: 3.8 - - # - name: Setup python dependencies - # run: pip install --upgrade mkdocs mkdocs-material pygments - - # - name: Build Docs - # run: | - # mkdocs build - # touch site/.nojekyll - # cd site && zip -r gh-pages . - - # - uses: actions/upload-artifact@v2 - # with: - # name: ${{ github.sha }} - # path: site/gh-pages.zip + - uses: actions/upload-artifact@v2 + with: + name: ${{ github.sha }} + path: build/* + + docs: + name: Build Docs + runs-on: ubuntu-latest + + steps: + - name: Checkout sources + uses: actions/checkout@v2 + + - name: Setup Python + uses: actions/setup-python@v2 + with: + python-version: 3.8 + + - name: Setup python dependencies + run: pip install --upgrade mkdocs mkdocs-material pygments + + - name: Build Docs + run: | + mkdocs build + touch site/.nojekyll + cd site && zip -r gh-pages . + + - uses: actions/upload-artifact@v2 + with: + name: ${{ github.sha }} + path: site/gh-pages.zip From d2176172ef2842fd1847c6543aa7f62c6369c7b2 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Tue, 12 Oct 2021 15:42:55 -0400 Subject: [PATCH 11/12] changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c92048bdd..881da990e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,7 +38,7 @@ ### Tools - `symsorter` no longer emits files with empty debug identifiers. ([#469](https://github.com/getsentry/symbolicator/pull/469)) -- MacOS x86_64 builds of symbolicator, symsorter and wasm-split can be downloaded from GitHub releases now. ([#565](https://github.com/getsentry/symbolicator/pull/565)) +- MacOS universal builds (x86_64 + ARM in one fat binary) of symbolicator, symsorter and wasm-split can be downloaded from GitHub releases now. ([#565](https://github.com/getsentry/symbolicator/pull/565), [#568](https://github.com/getsentry/symbolicator/pull/568)) ### Internal From b0b8a84e0cdd79de113984afd23dc8dc30cc83f8 Mon Sep 17 00:00:00 2001 From: Brad Kotsopoulos Date: Wed, 13 Oct 2021 11:36:18 -0400 Subject: [PATCH 12/12] add to craft.yml --- .craft.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.craft.yml b/.craft.yml index 1303f98ba..45c5313ec 100644 --- a/.craft.yml +++ b/.craft.yml @@ -33,3 +33,8 @@ requireNames: - /^symbolicator-Linux-x86_64-debug.zip$/ - /^symsorter-Linux-x86_64$/ - /^wasm-split-Linux-x86_64$/ + - /^symbolicator-Darwin-universal$/ + - /^wasm-split-Darwin-universal$/ + - /^symsorter-Darwin-universal$/ + - /^symbolicator-x86_64-apple-darwin-debug.zip$/ + - /^symbolicator-aarch64-apple-darwin-debug.zip$/