-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Support span level measurements #172
Comments
I just briefly talked to @AbhiPrasad: This should definitely be doable, but some ingestion related topics (sampling, scrubbing) might not be fully setup by now. Kinda related PR: https://github.com/getsentry/relay/pull/2969/files |
Quick update: This is still not implemented on all platforms. For cocoa measurements are set only on the root transaction. RN inherits the JS SDK impl, which only applies measurements on the root span as well. |
Context
According to our develop docs the span protocol supports measurements.
The relay protocol definition includes measurements as well.
Up until now our SDKs set the measurement value on the root transaction instead of the span itself. We should change that to allow measurements on a span level. This will help us reporting slow + frozen frames, frame delay, etc.
Tasks
The text was updated successfully, but these errors were encountered: