Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Explain/resolve "//TODO - remove dependency" in Button.tsx #110

Closed
voltrevo opened this issue Jan 24, 2022 · 1 comment · Fixed by #164
Closed

Explain/resolve "//TODO - remove dependency" in Button.tsx #110

voltrevo opened this issue Jan 24, 2022 · 1 comment · Fixed by #164
Assignees
@kautukkundan
Labels
extension Browser extension related

Comments

@voltrevo
Copy link
Collaborator

voltrevo commented Jan 24, 2022 •
edited
Loading

https://github.com/jzaki/bls-wallet/pull/103/files#r790366207
@voltrevo voltrevo mentioned this issue Jan 24, 2022
Merged
2 tasks
@kautukkundan
Copy link
Contributor

Remove highlight as a prop for button as the classes are supplied externally. Left it as is for now as some old code still use highlight separately.

@jacque006 jacque006 added the extension Browser extension related label Mar 7, 2022
@kautukkundan kautukkundan mentioned this issue Mar 10, 2022
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kautukkundan kautukkundan

Labels
extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addresses tech debts getwax/bls-wallet
3 participants
@voltrevo @jacque006 @kautukkundan