Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLSL back-end ignores stride on storage buffers #1504

Closed
ElectronicRU opened this issue Nov 2, 2021 · 0 comments · Fixed by #1507
Closed

HLSL back-end ignores stride on storage buffers #1504

ElectronicRU opened this issue Nov 2, 2021 · 0 comments · Fixed by #1507
Assignees
@kvark
Labels
area: back-end Outputs of shader conversion kind: bug Something isn't working lang: HLSL High-Level Shading Language

Comments

@ElectronicRU
Copy link
Contributor

ElectronicRU commented Nov 2, 2021 •
edited
Loading

Shader playground: https://shader-playground.timjones.io/4e4be36000db47ee5a8fadfe4e44701c

While debugging https://github.com/LPGhatguy/crevice/runs/4081541660 for LPGhatguy/crevice#27, I've faced the unfortunate reality that copying into/out of interface arrays ignores the array stride altogether. This means WGPU code on DX backend will be cross-non-portable, erroneously so probably, with Vulkan and GL backends.

Arrays of vec3 are not exactly rare, so I propose we fix this ASAP, this looks to me like a serious compatibility issue.
@cwfitzgerald cwfitzgerald added area: back-end Outputs of shader conversion kind: bug Something isn't working lang: HLSL High-Level Shading Language labels Nov 2, 2021
@ElectronicRU ElectronicRU mentioned this issue Nov 2, 2021
Open
@kvark kvark self-assigned this Nov 3, 2021
@kvark kvark mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
area: back-end Outputs of shader conversion kind: bug Something isn't working lang: HLSL High-Level Shading Language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hlsl: respect array stride in storage buffers kvark/naga
3 participants
@kvark @ElectronicRU @cwfitzgerald