Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spv-out: Don't decorate varyings with interpolation modes at pipeline start/end #2038

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

nical
Copy link
Contributor

@nical nical commented Sep 1, 2022

Fixes #2036.

@nical nical force-pushed the spv-flat-stage branch 2 times, most recently from 51e0d22 to 4780c54 Compare September 1, 2022 14:02
@nical nical changed the title Don't decorate builtins with interpolation modes at pipeline start/end spv: Don't decorate varyings with interpolation modes at pipeline start/end Sep 1, 2022
@nical nical changed the title spv: Don't decorate varyings with interpolation modes at pipeline start/end spv-out: Don't decorate varyings with interpolation modes at pipeline start/end Sep 1, 2022
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So straightforward! Looks great.

The snapshots need to be properly updated for CI.

@jimblandy jimblandy merged commit 6b3c111 into gfx-rs:master Sep 1, 2022
jimblandy added a commit to jimblandy/naga that referenced this pull request Sep 1, 2022
The Vulkan decoration rules require us to distinguish vertex shader
inputs, fragment shader inputs, and everything else, so just pass the
stage to `Writer::write_varying`. Together with the SPIRV storage
class, this is sufficient to distinguish all the cases in a way that
closely follows the spec language.
jimblandy added a commit to jimblandy/naga that referenced this pull request Sep 1, 2022
The Vulkan decoration rules require us to distinguish vertex shader
inputs, fragment shader inputs, and everything else, so just pass the
stage to `Writer::write_varying`. Together with the SPIRV storage
class, this is sufficient to distinguish all the cases in a way that
closely follows the spec language.
jimblandy added a commit that referenced this pull request Sep 1, 2022
The Vulkan decoration rules require us to distinguish vertex shader
inputs, fragment shader inputs, and everything else, so just pass the
stage to `Writer::write_varying`. Together with the SPIRV storage
class, this is sufficient to distinguish all the cases in a way that
closely follows the spec language.
@nical nical deleted the spv-flat-stage branch September 2, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spirv output fails with [VUID-StandaloneSpirv-Flat-06202] (wgpu water example)
2 participants