autogen: Convert from build script to runnable binary #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the autogen README rspirv-autogen is used to "automatically update files in anther crates". This use seems long-gone as none of the top-level projects depend on `rspirv-autogen`: regeneration does not happen at build-time anymore. However, when loading this project in an IDE that scans and `check`s all workspaces the build script _is_ invoked resulting in slow startup times and accidental regeneration, which is particularly inconvenient when SPIRV-Headers so happens to be checked out on a different commit.
|
I think this is a change for the better 👍 |
Jasper-Bekkers
approved these changes
Nov 25, 2020
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the autogen README rspirv-autogen is used to "automatically update files in anther crates". This use seems long-gone as none of the top-level projects depend on
rspirv-autogen: regeneration does not happen at build-time anymore.However, when loading this project in an IDE that scans and
checks all workspaces the build script is invoked resulting in slow startup times and accidental regeneration, which is particularly inconvenient when SPIRV-Headers so happens to be checked out on a different commit.With this PR the recommended way to regenerate is:
In addition regeneration happens in the CI now as well, to capture any accidental mismatches between the generator, submodule checkout and submitted code.
(Edit: no, I don't like ```console either.)