Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validation truly optional #4409

Closed
kvark opened this issue Dec 6, 2022 · 1 comment
Closed

Make validation truly optional #4409

kvark opened this issue Dec 6, 2022 · 1 comment
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator type: enhancement New feature or request

Comments

@kvark
Copy link
Member

kvark commented Dec 6, 2022

Currently, even with empty validation flags, the validator complains about things that aren't required to produce the module info. For example, it requires the @group and @binding to be present, unconditionally, on resources. This doesn't affect construction of ModuleInfo and should be gated behind a flag. Moreover, documentation of --validation option in naga-cli says:

--validate bitmask of the ValidationFlags to be used, use 0 to disable validation
@kvark kvark added kind: feature area: validation Issues related to validation, diagnostics, and error handling labels Dec 6, 2022
@kvark kvark mentioned this issue Dec 7, 2022
Merged
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@teoxoy
Copy link
Member

teoxoy commented Nov 16, 2023

Has been addressed by gfx-rs/naga#2156.

@teoxoy teoxoy closed this as completed Nov 16, 2023
@teoxoy teoxoy added the type: enhancement New feature or request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @cwfitzgerald @teoxoy