Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate access on ImageClass::Storage and AddressSpace::Storage #4411

Closed
teoxoy opened this issue Dec 8, 2022 · 1 comment
Closed

Validate access on ImageClass::Storage and AddressSpace::Storage #4411

teoxoy opened this issue Dec 8, 2022 · 1 comment
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator

Comments

@teoxoy
Copy link
Member

teoxoy commented Dec 8, 2022

WGSL only has write-only storage textures and never write-only storage buffers.

see https://gpuweb.github.io/gpuweb/wgsl/#texture-storage and https://gpuweb.github.io/gpuweb/wgsl/#storage-buffer


wgpu has support for read-only and read-write storage textures via Features::TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES.
Therefore we should add Capability::READ_ONLY_AND_READ_WRITE_STORAGE_TEXTURES that disables access validation for storage textures.

@teoxoy teoxoy added the area: validation Issues related to validation, diagnostics, and error handling label Dec 8, 2022
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@teoxoy teoxoy modified the milestone: WebGPU Specification V1 Nov 3, 2023
@teoxoy
Copy link
Member Author

teoxoy commented Nov 3, 2023

read-only and read-write storage textures have now landed in the core spec.

And #4370 is already tracking us removing write-only storage buffers.

@teoxoy teoxoy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator
Projects
None yet
Development

No branches or pull requests

2 participants