From 3963fb4db91ff5e94230f24773a92c627dd9e29a Mon Sep 17 00:00:00 2001 From: Erich Gubler Date: Thu, 27 Apr 2023 15:56:11 -0400 Subject: [PATCH 1/3] docs: note feature req. for `Depth32FloatStencil8` --- CHANGELOG.md | 4 ++++ wgpu-types/src/lib.rs | 2 ++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49048f2f4c..08b7b852c2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,10 @@ Bottom level categories: ## Unreleased +### Documentation + +- Document feature requirements for `DEPTH32FLOAT_STENCIL8` by @ErichDonGubler in [#3734](https://github.com/gfx-rs/wgpu/pull/3734). + ## v0.16.0 (2023-04-19) ### Major changes diff --git a/wgpu-types/src/lib.rs b/wgpu-types/src/lib.rs index 98481be8b4..35aeab2085 100644 --- a/wgpu-types/src/lib.rs +++ b/wgpu-types/src/lib.rs @@ -2025,6 +2025,8 @@ pub enum TextureFormat { /// Special depth format with 32 bit floating point depth. Depth32Float, /// Special depth/stencil format with 32 bit floating point depth and 8 bits integer stencil. + /// + /// [`Features::DEPTH32FLOAT_STENCIL8`] must be enabled to use this texture format. Depth32FloatStencil8, // Compressed textures usable with `TEXTURE_COMPRESSION_BC` feature. From 9066fdf2780479345d00a7bc3dfd848120724c8c Mon Sep 17 00:00:00 2001 From: Erich Gubler Date: Thu, 27 Apr 2023 16:16:37 -0400 Subject: [PATCH 2/3] docs: style `spirv-passthrough`/`naga` refs. consistently --- wgpu-types/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wgpu-types/src/lib.rs b/wgpu-types/src/lib.rs index 35aeab2085..a4af880ef2 100644 --- a/wgpu-types/src/lib.rs +++ b/wgpu-types/src/lib.rs @@ -270,7 +270,7 @@ bitflags::bitflags! { /// Allows shaders to acquire the FP16 ability /// - /// Note: this is not supported in naga yet，only through spir-v passthrough right now. + /// Note: this is not supported in `naga` yet，only through `spirv-passthrough` right now. /// /// Supported Platforms: /// - Vulkan @@ -728,7 +728,7 @@ bitflags::bitflags! { /// /// This is a native only feature. const SHADER_F64 = 1 << 59; - /// Allows shaders to use i16. Not currently supported in naga, only available through `spirv-passthrough`. + /// Allows shaders to use i16. Not currently supported in `naga`, only available through `spirv-passthrough`. /// /// Supported platforms: /// - Vulkan From cff9fe81370a8d9cc1e6e18ddda669a2a7603854 Mon Sep 17 00:00:00 2001 From: Erich Gubler Date: Thu, 27 Apr 2023 16:26:07 -0400 Subject: [PATCH 3/3] chore(wgpu-core): remove period from `CreateTextureError::MissingFeatures` msg. --- wgpu-core/src/resource.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wgpu-core/src/resource.rs b/wgpu-core/src/resource.rs index 7abc20343b..6ea7b9cce0 100644 --- a/wgpu-core/src/resource.rs +++ b/wgpu-core/src/resource.rs @@ -523,7 +523,7 @@ pub enum CreateTextureError { InvalidSampleCount(u32, wgt::TextureFormat), #[error("Multisampled textures must have RENDER_ATTACHMENT usage")] MultisampledNotRenderAttachment, - #[error("Texture format {0:?} can't be used due to missing features.")] + #[error("Texture format {0:?} can't be used due to missing features")] MissingFeatures(wgt::TextureFormat, #[source] MissingFeatures), #[error(transparent)] MissingDownlevelFlags(#[from] MissingDownlevelFlags),