Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrmaAdapter::getRelation ignores orderby? #292

Closed
mk2 opened this issue Sep 25, 2016 · 1 comment
Closed

OrmaAdapter::getRelation ignores orderby? #292

mk2 opened this issue Sep 25, 2016 · 1 comment
Labels
Milestone

Comments

@mk2
Copy link

mk2 commented Sep 25, 2016

Thank you for very useful library.

I used OrmaRecyclerViewAdapter, and found that my orderby spec was not effected to recyclerview.

Problem:
When Child_Relation::clone was called, the super constructor is called continuously. But Relation constructor doesn't handle its orderSpecs ( https://github.com/gfx/Android-Orma/blob/v2.6.0/library/src/main/java/com/github/gfx/android/orma/Relation.java#L51-L53 )
So, current OrmaAdapter::getRelation ignore the given relation's orderby spec as a result.

Would my understandings not be accurate?

@gfx gfx added the bug label Sep 29, 2016
@gfx gfx added this to the v3.0.0 milestone Oct 10, 2016
@gfx
Copy link
Member

gfx commented Oct 11, 2016

Sorry to be late. This is fixed in #298 and should be included to v3.0.0-rc3.

@gfx gfx closed this as completed in #298 Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants