Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug that where(block) includes duplicated clause #415

Merged
merged 1 commit into from
May 24, 2017
Merged

fix a bug that where(block) includes duplicated clause #415

merged 1 commit into from
May 24, 2017

Conversation

k-kagurazaka
Copy link
Member

The result of clone() completely has the current clause, so there is no need to pass it to where again.

@gfx
Copy link
Member

gfx commented May 24, 2017

Oh 😲

Thanks.

@gfx gfx merged commit 8f3c6f2 into maskarade:master May 24, 2017
@k-kagurazaka k-kagurazaka deleted the fix-where-function-bug branch May 24, 2017 10:09
@k-kagurazaka
Copy link
Member Author

In this PR, I notice that I added a bug that where(block) condition isn't wrapped by parenthesis, so where(block) does nothing.
I'm going to send a new PR to solve the issue.
Sorry 🙇

@k-kagurazaka k-kagurazaka mentioned this pull request Jun 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-kagurazaka @gfx