Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example whisper.wasm is different than example #577

Closed
DavidGOrtega opened this issue Mar 6, 2023 · 2 comments
Closed

example whisper.wasm is different than example #577

DavidGOrtega opened this issue Mar 6, 2023 · 2 comments
Labels
question Further information is requested

Comments

@DavidGOrtega
Copy link

DavidGOrtega commented Mar 6, 2023

The example at https://whisper.ggerganov.com/ differs from the repo.
There is no threads in the repo example so the index-tmpl.html and emscripten.cpp should be different

Found in index-tmpl.html at https://whisper.ggerganov.com/

Module.full_default(instance, audio, document.getElementById('language').value, nthreads, translate)

vs

Module.full_default(instance, audio, document.getElementById('language').value, translate)
emscripten::function("full_default", emscripten::optional_override([](size_t index, const emscripten::val & audio, const std::string & lang, bool translate) {
@DavidGOrtega DavidGOrtega changed the title example whisper.wasm is missing some files example whisper.wasm is different than example Mar 7, 2023
@ggerganov ggerganov added the question Further information is requested label Mar 7, 2023
@ggerganov
Copy link
Owner

The current live version at https://whisper.ggerganov.com/ is built from the 4-bit branch. The changes are there, but not yet on master

@DavidGOrtega
Copy link
Author

Awesome work! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants