Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Export metrics of sip server. #49

Open
YiuTerran opened this issue Nov 24, 2022 · 3 comments
Open

[Feature Request] Export metrics of sip server. #49

YiuTerran opened this issue Nov 24, 2022 · 3 comments
Labels
pinned Issues don't touched by stalebot

Comments

@YiuTerran
Copy link
Contributor

When using in product env, we usually want to export service metrics to Prometheus.

For example, the client count (using TCP/UDP), transaction count, active dialog count, err rate, etc.

Maybe we should add some more functions for this purpose.

@ghettovoice
Copy link
Owner

Hello @YiuTerran ,
I agree that in prod env it can be useful.
I can expose TCP connections number, transactions number, it should be quit easy.
Dialogs is currently out of this lib's scope, so I'm not sure how to provide some reliable stats about them.
And regarding errors rate, I guess it would be a complex task... However, probably it should be bound to some meaningful contexts, for example transactions error rate and so on. I need to think about this, there are quit a mess currently.

@YiuTerran
Copy link
Contributor Author

YiuTerran commented Dec 12, 2022

I also searched for trace spec of sip, but only found this:

open-telemetry/semantic-conventions#1114

maybe we can add just add traceparent and tracestate header just like the HTTP protocol.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 16, 2023
@ghettovoice ghettovoice added pinned Issues don't touched by stalebot and removed stale labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Issues don't touched by stalebot
Projects
None yet
Development

No branches or pull requests

2 participants