Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle filter row option disappeared once language switched in Angular SlickGrid #438

Closed
sundaramoorthyjeeva opened this issue May 4, 2020 · 1 comment · Fixed by #448
Labels

Comments

@sundaramoorthyjeeva
Copy link

sundaramoorthyjeeva commented May 4, 2020

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular 7.3.5
Angular-Slickgrid 2.17.10
TypeScript 3.1.6
Operating System Windows 10
Node 10.16.3
NPM 6.9.0

Describe the Bug

I am using Angular Slickgrid in my application and I am facing an issue in the slick grid option. Here I described my scenario. First I have applied Toggle Filter Row option in the right corner. Then I switched the language, now I seen the list of option which available at the right corner. I cannot see the Toggle Filter Row option, its disappeared.

Steps to Reproduce

I have mentioned the below link which has the screen record clip taken from your samples. Please check and advise. Thanks. https://www.loom.com/share/58bcd0850ba844cf8140c2d48121a9de

Expected Behavior

Toggle Filter Row should not disapprear ever.

Current Behavior

I am using Angular Slickgrid in my application and I am facing an issue in the slick grid option. Here I described my scenario. First I have applied Toggle Filter Row option in the right corner. Then I switched the language, now I seen the list of option which available at the right corner. I cannot see the Toggle Filter Row option, its disappeared.
I explained this case in Stackoverflow as well. Please the stackoverflow link below.
https://stackoverflow.com/questions/61505151/toggle-filter-row-option-disapperaed-once-language-switched-in-angular-slickgrid?noredirect=1#comment108869400_61505151

Possible Solution

Code Sample

@ghiscoding ghiscoding added the bug label May 4, 2020
@ghiscoding ghiscoding changed the title Toggle filter row option disapperaed once language switched in Angular SlickGrid Toggle filter row option disappeared once language switched in Angular SlickGrid May 5, 2020
ghiscoding-SE added a commit that referenced this issue May 6, 2020
- this command "Toggle Filter Row" disappeared if it happens to have the filter row hidden when calling translate. This PR fixes it but while fixing this, it was also found that the Filter row MUST be visible BEFORE calling the translation service else the filters don't get recreated and that is even worst.
ghiscoding added a commit that referenced this issue May 6, 2020
- this command "Toggle Filter Row" disappeared if it happens to have the filter row hidden when calling translate. This PR fixes it but while fixing this, it was also found that the Filter row MUST be visible BEFORE calling the translation service else the filters don't get recreated and that is even worst.

Co-authored-by: Ghislain Beaulac <ghislain.beaulac@se.com>
@ghiscoding
Copy link
Owner

Fixed with a side effect, see PR #448 for more details.

Note however that I won't release a new version until couple more weeks, I want to finish some other features before I'm ready for a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants