Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rowDetail): use latest SlickGrid to fix issue with id, fixes #440 #449

Merged
merged 1 commit into from
May 6, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 6, 2020

  • fixes Row Details useRowClick false does not work #440
  • there was a small issue in core lib when using "datasetIdPropertyName" other than "id" so update to latest SlickGrid version which has the fix
  • change default grid options of Row Detail "useRowClick" property to false

- there was a small issue in core lib when using "datasetIdPropertyName" other than "id" so update to latest SlickGrid version which has the fix
- change default grid options of Row Detail "useRowClick" property to false
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #449    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          147       147            
  Lines         9199      9199            
  Branches      3054      3182   +128     
==========================================
  Hits          9199      9199            
Impacted Files Coverage Δ
...p/modules/angular-slickgrid/global-grid-options.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10c5be...5412a69. Read the comment docs.

@ghiscoding ghiscoding merged commit 8f16559 into master May 6, 2020
@ghiscoding ghiscoding deleted the bugfix/row-detail-row-click branch May 6, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row Details useRowClick false does not work
2 participants