From 27e983e084dc6854db4af90d32c86e0687c95fe1 Mon Sep 17 00:00:00 2001
From: ghiscoding <gbeaulac@gmail.com>
Date: Thu, 29 Aug 2024 00:50:47 -0400
Subject: [PATCH] fix: only import `@excel-builder-vanilla/types` for optional
 dep - since `excel-builder-vanilla` is an optional dependency, we should only
 import its types, I created a separate types only package to deal with that

---
 packages/common/package.json                  |  2 +-
 .../columnExcelExportOption.interface.ts      |  2 +-
 .../interfaces/excelExportOption.interface.ts |  2 +-
 packages/excel-export/package.json            |  2 +-
 pnpm-lock.yaml                                | 20 ++++++++++++-------
 5 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/packages/common/package.json b/packages/common/package.json
index 53eb37f11..8118802ef 100644
--- a/packages/common/package.json
+++ b/packages/common/package.json
@@ -66,6 +66,7 @@
     "not dead"
   ],
   "dependencies": {
+    "@excel-builder-vanilla/types": "^3.0.3",
     "@formkit/tempo": "^0.1.2",
     "@slickgrid-universal/binding": "workspace:~",
     "@slickgrid-universal/event-pub-sub": "workspace:~",
@@ -74,7 +75,6 @@
     "@types/trusted-types": "^2.0.7",
     "autocompleter": "^9.3.2",
     "dequal": "^2.0.3",
-    "excel-builder-vanilla": "3.0.1",
     "multiple-select-vanilla": "^3.3.2",
     "sortablejs": "^1.15.2",
     "un-flatten-tree": "^2.0.12",
diff --git a/packages/common/src/interfaces/columnExcelExportOption.interface.ts b/packages/common/src/interfaces/columnExcelExportOption.interface.ts
index b68482ff9..90479035b 100644
--- a/packages/common/src/interfaces/columnExcelExportOption.interface.ts
+++ b/packages/common/src/interfaces/columnExcelExportOption.interface.ts
@@ -1,4 +1,4 @@
-import type { ExcelColumnMetadata, ExcelStyleInstruction, StyleSheet } from 'excel-builder-vanilla';
+import type { ExcelColumnMetadata, ExcelStyleInstruction, StyleSheet } from '@excel-builder-vanilla/types';
 
 import type { Column } from './column.interface';
 import type { GridOption } from './gridOption.interface';
diff --git a/packages/common/src/interfaces/excelExportOption.interface.ts b/packages/common/src/interfaces/excelExportOption.interface.ts
index 8881b74d7..4b2584a7f 100644
--- a/packages/common/src/interfaces/excelExportOption.interface.ts
+++ b/packages/common/src/interfaces/excelExportOption.interface.ts
@@ -1,4 +1,4 @@
-import type { ExcelStyleInstruction, Worksheet, Workbook } from 'excel-builder-vanilla';
+import type { ExcelStyleInstruction, Worksheet, Workbook } from '@excel-builder-vanilla/types';
 import type { FileType } from '../enums/fileType.enum';
 
 export interface ExcelExportOption {
diff --git a/packages/excel-export/package.json b/packages/excel-export/package.json
index 1151a2474..dfca36db6 100644
--- a/packages/excel-export/package.json
+++ b/packages/excel-export/package.json
@@ -51,7 +51,7 @@
   "dependencies": {
     "@slickgrid-universal/common": "workspace:~",
     "@slickgrid-universal/utils": "workspace:~",
-    "excel-builder-vanilla": "^3.0.1"
+    "excel-builder-vanilla": "^3.0.3"
   },
   "devDependencies": {
     "@slickgrid-universal/event-pub-sub": "workspace:~"
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 7aedbe4be..6f2de923b 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -222,6 +222,9 @@ importers:
 
   packages/common:
     dependencies:
+      '@excel-builder-vanilla/types':
+        specifier: ^3.0.3
+        version: 3.0.3
       '@formkit/tempo':
         specifier: ^0.1.2
         version: 0.1.2
@@ -246,9 +249,6 @@ importers:
       dequal:
         specifier: ^2.0.3
         version: 2.0.3
-      excel-builder-vanilla:
-        specifier: 3.0.1
-        version: 3.0.1
       multiple-select-vanilla:
         specifier: ^3.3.2
         version: 3.3.2
@@ -345,8 +345,8 @@ importers:
         specifier: workspace:~
         version: link:../utils
       excel-builder-vanilla:
-        specifier: ^3.0.1
-        version: 3.0.1
+        specifier: ^3.0.3
+        version: 3.0.3
     devDependencies:
       '@slickgrid-universal/event-pub-sub':
         specifier: workspace:~
@@ -1346,6 +1346,12 @@ packages:
     engines: {node: ^18.18.0 || ^20.9.0 || >=21.1.0}
     dev: true
 
+  /@excel-builder-vanilla/types@3.0.3:
+    resolution: {integrity: sha512-zrIV6x+CjeoFAbYjpxGyrb0dJXmAq+QUOZa3/Y6O3KO4brf+HbVrtjUHkFqiaJnu5jFSgBhM3GrohNiOrd9RnQ==}
+    dependencies:
+      fflate: 0.8.2
+    dev: false
+
   /@faker-js/faker@8.4.1:
     resolution: {integrity: sha512-XQ3cU+Q8Uqmrbf2e0cIC/QN43sTBSC8KF12u29Mb47tWrt2hAgBXSgpZMj4Ao8Uk0iJcU99QsOCaIL8934obCg==}
     engines: {node: ^14.17.0 || ^16.13.0 || >=18.0.0, npm: '>=6.14.13'}
@@ -4765,8 +4771,8 @@ packages:
     resolution: {integrity: sha512-GWkBvjiSZK87ELrYOSESUYeVIc9mvLLf/nXalMOS5dYrgZq9o5OVkbZAVM06CVxYsCwH9BDZFPlQTlPA1j4ahA==}
     dev: true
 
-  /excel-builder-vanilla@3.0.1:
-    resolution: {integrity: sha512-pVB10+81o16pB9ERoku0vjvPEQgVH3amKCAw8qU1hc2XiKKLn0gJS/cIb8/QzIsC/51gcRDswJLBSzfUzm1nfw==}
+  /excel-builder-vanilla@3.0.3:
+    resolution: {integrity: sha512-2G39hN7RiTRqwolUJOqz41o4t3VZC6oaOpJCSuzOGMKSOdPE7fxDVEaoQnsImHxu5SlVXUYvYsL0t0Dh2gFFyg==}
     dependencies:
       fflate: 0.8.2
     dev: false