Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot refer to dateFilterCondition #1077

Closed
5 tasks done
boogiebug opened this issue Aug 17, 2023 · 2 comments
Closed
5 tasks done

cannot refer to dateFilterCondition #1077

boogiebug opened this issue Aug 17, 2023 · 2 comments

Comments

@boogiebug
Copy link
Contributor

Describe the bug

I'm creating a custom server service. and cannot refer the exported function executeDateFilterCondition in packages/common/src/filter-conditions/dateFilterCondition.ts.

I suppose that this package (dateFilterCondition) should be als exported in packages/common/src/filter-conditions as others in the same folder but it's missing.

Current content of the file filter-conditions/index.ts is:

export * from './stringFilterCondition';
export * from './objectFilterCondition';
export * from './numberFilterCondition';
export * from './filterUtilities';
export * from './filterConditions.index';
export * from './filterConditionProcesses';
export * from './collectionSearchFilterCondition';
export * from './booleanFilterCondition';

I suppose the the following line is missing?

export * from './dateFilterCondition';

Reproduction

This is not a run-time bug, but the compile time bug. To reproduce this bug, simply refer to any exported function from dateFilterCondition module in the source code and the compile errors will be appeared.

Which Framework are you using?

Angular

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| Slickgrid-Universal | 3.1     |
| TypeScript          | 4.9     |

Validations

@ghiscoding
Copy link
Owner

I'm not sure why you would want to extend these filter conditions, I mean I'm curious to see why. So yes, it looks like it is missing and a Pull Request is certainly welcome. I'm expecting to push a new release in the next couple days so it would be nice if you have the time to create a PR. Thanks

@ghiscoding
Copy link
Owner

closed by #1078, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants